[llvm-commits] CVS: llvm/lib/AsmParser/ParserInternals.h llvmAsmParser.y

[Chris Lattner]

Changes in directory llvm/lib/AsmParser:

ParserInternals.h updated: 1.33 -> 1.34
llvmAsmParser.y updated: 1.143 -> 1.144

---
Log message:

Minor cleanups, plug a minor memory leak


---
Diffs of the changes:  (+2 -5)

Index: llvm/lib/AsmParser/ParserInternals.h
diff -u llvm/lib/AsmParser/ParserInternals.h:1.33 llvm/lib/AsmParser/ParserInternals.h:1.34
--- llvm/lib/AsmParser/ParserInternals.h:1.33	Tue Nov 11 16:41:32 2003
+++ llvm/lib/AsmParser/ParserInternals.h	Tue Dec 23 14:05:15 2003
@@ -67,8 +67,7 @@
 // discriminated union.
 //
 // Note that I can't implement this class in a straight forward manner with 
-// constructors and stuff because it goes in a union, and GCC doesn't like 
-// putting classes with ctor's in unions.  :(
+// constructors and stuff because it goes in a union.
 //
 struct ValID {
   enum {


Index: llvm/lib/AsmParser/llvmAsmParser.y
diff -u llvm/lib/AsmParser/llvmAsmParser.y:1.143 llvm/lib/AsmParser/llvmAsmParser.y:1.144
--- llvm/lib/AsmParser/llvmAsmParser.y:1.143	Wed Nov 26 01:24:58 2003
+++ llvm/lib/AsmParser/llvmAsmParser.y	Tue Dec 23 14:05:15 2003
@@ -1122,10 +1122,8 @@
     
       if (I != CurModule.GlobalRefs.end()) {
 	V = I->second;             // Placeholder already exists, use it...
+        $2.destroy();
       } else {
-	// TODO: Include line number info by creating a subclass of
-	// TODO: GlobalVariable here that includes the said information!
-	
 	// Create a placeholder for the global variable reference...
 	GlobalVariable *GV = new GlobalVariable(PT->getElementType(),
                                                 false,