[llvm-commits] CVS: llvm/lib/VMCore/SlotCalculator.cpp

Alkis Evlogimenos alkis at cs.uiuc.edu
Thu Oct 30 21:03:00 PST 2003


Changes in directory llvm/lib/VMCore:

SlotCalculator.cpp updated: 1.36 -> 1.37

---
Log message:

Use already existing classes for post order iterator.


---
Diffs of the changes:  (+11 -17)

Index: llvm/lib/VMCore/SlotCalculator.cpp
diff -u llvm/lib/VMCore/SlotCalculator.cpp:1.36 llvm/lib/VMCore/SlotCalculator.cpp:1.37
--- llvm/lib/VMCore/SlotCalculator.cpp:1.36	Thu Oct 30 15:04:44 2003
+++ llvm/lib/VMCore/SlotCalculator.cpp	Thu Oct 30 21:02:34 2003
@@ -23,7 +23,7 @@
 #include "llvm/Constant.h"
 #include "llvm/DerivedTypes.h"
 #include "llvm/SymbolTable.h"
-#include "Support/DepthFirstIterator.h"
+#include "Support/PostOrderIterator.h"
 #include "Support/STLExtras.h"
 #include <algorithm>
 
@@ -287,26 +287,20 @@
     SC_DEBUG("  Inserted type: " << TheTy->getDescription() << " slot=" <<
              ResultSlot << "\n");
 
-    // Loop over any contained types in the definition... in reverse depth
-    // first order.
+    // Loop over any contained types in the definition... in post
+    // order.
     //
-    std::vector<const Type*> DfsOrder;
-    for (df_iterator<const Type*> I = df_begin(TheTy), E = df_end(TheTy);
+    for (po_iterator<const Type*> I = po_begin(TheTy), E = po_end(TheTy);
          I != E; ++I) {
       if (*I != TheTy) {
-	// If we haven't seen this sub type before, add it to our type table!
-	DfsOrder.push_back(*I);
-      }
-    }
-
-    for (std::vector<const Type*>::const_reverse_iterator
-             I = DfsOrder.rbegin(), E = DfsOrder.rend(); I != E; ++I) {
         const Type *SubTy = *I;
-      if (getSlot(SubTy) == -1) {
-	SC_DEBUG("  Inserting subtype: " << SubTy->getDescription() << "\n");
-        int Slot = doInsertValue(SubTy);
-        SC_DEBUG("  Inserted subtype: " << SubTy->getDescription() << 
-                 " slot=" << Slot << "\n");
+	// If we haven't seen this sub type before, add it to our type table!
+        if (getSlot(SubTy) == -1) {
+          SC_DEBUG("  Inserting subtype: " << SubTy->getDescription() << "\n");
+          int Slot = doInsertValue(SubTy);
+          SC_DEBUG("  Inserted subtype: " << SubTy->getDescription() << 
+                   " slot=" << Slot << "\n");
+        }
       }
     }
     return ResultSlot;





More information about the llvm-commits mailing list