[llvm-commits] CVS: llvm/lib/Transforms/Scalar/InstructionCombining.cpp

[Chris Lattner]

Changes in directory llvm/lib/Transforms/Scalar:

InstructionCombining.cpp updated: 1.82 -> 1.83

---
Log message:

Minor cleanups.
This hunk:
-    } else if (Src->getNumOperands() == 2 && Src->use_size() == 1) {
+    } else if (Src->getNumOperands() == 2) {

Allows GEP folding to be more aggressive, which reduces the number of instructions 
and can dramatically speed up BasicAA in some cases.


---
Diffs of the changes:

Index: llvm/lib/Transforms/Scalar/InstructionCombining.cpp
diff -u llvm/lib/Transforms/Scalar/InstructionCombining.cpp:1.82 llvm/lib/Transforms/Scalar/InstructionCombining.cpp:1.83
--- llvm/lib/Transforms/Scalar/InstructionCombining.cpp:1.82	Tue May 20 13:45:35 2003
+++ llvm/lib/Transforms/Scalar/InstructionCombining.cpp	Thu May 22 14:07:21 2003
@@ -18,10 +18,7 @@
 #include "llvm/Transforms/Utils/BasicBlockUtils.h"
 #include "llvm/Transforms/Utils/Local.h"
 #include "llvm/ConstantHandling.h"
-#include "llvm/iMemory.h"
-#include "llvm/iOther.h"
-#include "llvm/iPHINode.h"
-#include "llvm/iOperators.h"
+#include "llvm/Instructions.h"
 #include "llvm/Pass.h"
 #include "llvm/DerivedTypes.h"
 #include "llvm/Support/InstIterator.h"
@@ -941,7 +938,7 @@
 
 
 Instruction *InstCombiner::visitGetElementPtrInst(GetElementPtrInst &GEP) {
-  // Is it 'getelementptr %P, uint 0'  or 'getelementptr %P'
+  // Is it 'getelementptr %P, long 0'  or 'getelementptr %P'
   // If so, eliminate the noop.
   if ((GEP.getNumOperands() == 2 &&
        GEP.getOperand(1) == Constant::getNullValue(Type::LongTy)) ||
@@ -956,8 +953,8 @@
     std::vector<Value *> Indices;
   
     // Can we combine the two pointer arithmetics offsets?
-     if (Src->getNumOperands() == 2 && isa<Constant>(Src->getOperand(1)) &&
-         isa<Constant>(GEP.getOperand(1))) {
+    if (Src->getNumOperands() == 2 && isa<Constant>(Src->getOperand(1)) &&
+        isa<Constant>(GEP.getOperand(1))) {
       // Replace: gep (gep %P, long C1), long C2, ...
       // With:    gep %P, long (C1+C2), ...
       Value *Sum = *cast<Constant>(Src->getOperand(1)) +
@@ -967,7 +964,7 @@
       GEP.setOperand(1, Sum);
       AddUsesToWorkList(*Src);   // Reduce use count of Src
       return &GEP;
-    } else if (Src->getNumOperands() == 2 && Src->use_size() == 1) {
+    } else if (Src->getNumOperands() == 2) {
       // Replace: gep (gep %P, long B), long A, ...
       // With:    T = long A+B; gep %P, T, ...
       //