[llvm-commits] CVS: llvm/lib/CWriter/Writer.cpp

[Chris Lattner]

> Fixed problem with printing struct definitions in the correct order.
> This allows for the
> Regression/Transforms/ScalarReplacement/scalarize.c to run correctly.

The change looks great.  One comment though:

The StructPrinted set is only used during the printing phase.  Could you
please move it so that instead of being part of the main CWriter object,
it would be a temporary in the caller of parseStruct?  ParseStruct would
have to be modified to take the set as an argument (by reference) but
other than that, everything should stay the same.

Thanks again for fixing this bug!

-Chris

http://llvm.cs.uiuc.edu/
http://www.nondot.org/~sabre/Projects/