<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/217371>217371</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            [Mips][IAS] PIC la incorrectly treats an defined global symbol as local
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            new issue
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          FlyGoat
      </td>
    </tr>
</table>

<pre>
    The IAS classifies any symbol that is already in a section as local when expanding the PIC `la` macro. A defined symbol can still have global ELF binding, so this makes the expansion depend incorrectly on whether the symbol is defined before or after its use.

For an O32 default-visible global defined before `la`, IAS emits the local GOT sequence using `R_MIPS_GOT16` followed by `R_MIPS_LO16`. The global GOT entry already contains the complete symbol address, so adding the low part again produces an incorrect address when the symbol has a nonzero low part.

gas uses the symbol's ELF binding and emits the global GOT form.

## Reproducer

```asm
.option pic2

.data
.space 4
.globl global_symbol
global_symbol:
  .word 0

.local local_symbol
local_symbol:
  .word 0

.text
la $5, global_symbol
la $25, global_symbol
la $6, local_symbol
```

Assemble and inspect:

```sh
llvm-mc \
  -triple=mips-unknown-linux \
 -mcpu=mips32r2 \
  -filetype=obj \
  defined-global.s \
  -o defined-global.o

llvm-readelf --symbols --relocations defined-global.o
```

### Actual

IAS treats both symbols as local because both have already been defined in `.data`:

```text
R_MIPS_GOT16 global_symbol
R_MIPS_LO16  global_symbol
R_MIPS_GOT16 global_symbol
R_MIPS_LO16  global_symbol
R_MIPS_GOT16 .data
R_MIPS_LO16 .data
```

The first two relocations correspond to the ordinary `la`, and the next two correspond to `la $25, global_symbol`.

For a global symbol, the GOT entry contains the complete address. The generated code then adds `%lo(global_symbol)` a second time, producing the wrong result when the low part is non-zero.

### Expected

For O32 without XGOT, gas emits:

```text
R_MIPS_GOT16  global_symbol
R_MIPS_CALL16 global_symbol
R_MIPS_GOT16  .data
R_MIPS_LO16   .data
```

IAS should classify symbols using their ELF binding rather than whether they have already been assigned to a section.
</pre>
<img width="1" height="1" alt="" src="http://email.email.llvm.org/o/eJykVk1v2zgT_jXyZSBBpiN_HHxwkzoIkCJFm8N7C0bi2GJLkXo5VBzvr1-QkmU7TRYLLBDENud75pmHRGa1N0TrpPiSFHcT7Hxt3Xqrj_cW_aS08rh-rgkeNj-h0kF7p4gBzRH42JRWg6_Rg2JA7QjlEZQBBKbKK2sAGbStUMOhJgP01qKRyuzB1wTfH24hmecak3kODVbOZrABSTtlSJ68V2iAvdIaanwl2Gtbooavj1soVXSViFtgC75WDA3-Jo6-YyQOGUhqyUhQprLOUeX1EawJ6fiaXNQdIikeY5e0s47AOsCdJwfKM3RMWZJvknyzDecGnmYiGGCnffqqWJV6TO-dn1ORIdXQR2qCwxC678390zMw_b8jUxF0HPqTzPMfL98evv98uX96ns5Dh3ZWa3sIXo8X4senKM0gDGkIH_yR8e44zqSyxqMyfdDKNq0mPxaOUjpiHhqJchyQtgdo0XnAPSoDrbOyq-Lwz-08WfcDvmhnjQwIxpq_yNnR1dDCPcaG8oVBIhZ8OVdAIy86dVHazrpm8JOIWSJm8IOG3NxwPM_7P-QmyTeZbSMYW1WJXiGT6DF8cosVwU34GiLoIc7LkFO-uf49C8YA2cE6Cfngqx9i_H-2u_r5oZmnNx8UERJxU4Tuv4_di8Q_yOZB9C7yWHwfZ8NMTcAmxi3glirfJ3Spy3XwqV-btKkgKW5jvql3qtWUzO4a1XLamd_GHkyqleneTkppU7XdoDETTpyNd0qTP7bB3Ja_xvNhN9K-oIzPBva9zPZJxrQCjknvIE37QhnS1FEoPYyWPzS9bkSPlQCXTeU71P1p2EfvCD1DaX0NJ-8jcZVUYcfUSyMHnZaqJDLjqisTlrLH1Tz_s8HDtC-X-o-ZXqw0fCb8r5Yn5F9anM7eNSwwyk459uAPFi6bHXefW2skeBvX0zqpDLrjFdcFxAWhobfex7VdVP0M4fP8km1P63-iitvo98xzH_PbQE0DN5Ihh54kVFZSUDRBgSEmW2ibiOV1CmIVaDfeZTFj1VCI3FPNiSMPzpo9OOJO-zMHjsypOFBgGjgwew_Dr29hF0me6wxXykH52nYe_nf_9BzbgtzT4L_D1GfTv908Pn4OnMH2I3DAZ_AIm8O17bQ8PQyO4_b0l5ivSbkrTnc43Lp4dQUfP1is4WESkTK-J7KJXM_karbCCa2ni-ViWsxWq3xSr_NisVxW5ZTkbrpc4nK1KOR0saQcZ1OqKpyotcjFPF9OV8GmyLMKy-VsupyXcjVfLIp5cpNTg0pngW8y6_YTxdzRWkwXs8V0orEkzfGZJIShA0RpIkR4Nbl1JKmy23Nyk2vFns9uvPI6vq--qZaT4i4pvjxsfibFXXwBabx6mwxchGdmuYL-yEuTzul17X0bcSG2idjula-7Mqtsk4htiD58pK2zvwLri23MmROxHYp6XYu_AwAA__-vL0Lt">