<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/185649>185649</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            [X86] Investigate outstanding X86SelectionDAGInfo::verifyTargetNode warnings
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            backend:X86
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          RKSimon
      </td>
    </tr>
</table>

<pre>
    #168421 left a number of unaddressed issues with some target opcodes that need fixing to allow us to remove the method entirely:

https://github.com/llvm/llvm-project/pull/168421/changes#r2537873708

X86ISD::INSERTQI/EXTRQI - we don't really care about the type - we should either cast everything to MVT::v2i64 or adjust the defs in X86InstrFragmentsSIMD.td to allow any (matching) 128-bit vector type.

The others I haven't investigated much but verifyTargetNode should make it trivial to identify the incorrect node creations.

Split the work - comment on the ticket which node types your working on.
</pre>
<img width="1" height="1" alt="" src="http://email.email.llvm.org/o/eJyUU9GK6zYU_Br55bAhlhzHfvDDltyUUO6FuwllX2XpxNJdWQrSsVP_fZG97ULfCgbboDOamTMjU7KDR-zY4Td2OBVyIhNi9_bH1Y7BF33QS8e4KOum4iU4vBNI8NPYY4Rwh8lLrSOmhBpsShMmeFoykMKIQDIOSBAeKmhMQEYSeEQNd_uX9QNQAOlceMKU8nfEMcwIZBBGJBM0oCcb0S1MvLJ9fgzRI-U_fmb8PFgyU79TYWT87Nz8z-vlEcMvVMT4-TE5x_h5o8_4WRnpB0yMi8gP4tgcxXHfbNjvTX25njK4eL38uH57u_28MH7-9n57-3mBF3gi6OAZPxJElM4toGREkH2YaCVNywO3c8mEyWlASwYjKJkIcMa4kPmU_f3P23bRzG1dQYgg9a8pbTga7wmsh0zIJ4rnKIcRPaXr5ftpR_rLN-kXYLwZJamMzHgLJW9eekswo6IQV067Td_NIIRMKMEFjJxx02L9jInsIAk1jJMy0E95PNr7clsX-CPofyWN8gPBElC0s5UuU7E6r-m-rNytVyFGVAQ-T6mIkmzw6ZPD9eHsJvIZ4ge8gApjlgbBbxZa9YEET2OV2RCygARLmOI6kv0LflfoTuhWtLLArjweRVm1ByEK01WHnsuqlL08ctHUfd9W92Oj2oo3al9hW9iO73m9F-W-FIKXfNe2TS1kc6iFqnTVc1btcZTW7XKSdiEOxZrrrmwOddUWTvbo0toWznupPtBrJnJ4GOe5QLFbI9hPQ2LV3tlE6QuKLLm1avn84QSXL_MhTJRIep0lvjf1FR2q7N3p9feLv4fPvPx3L08ZvfVDKqbouv9dj62yuSCburnjfwcAAP__PJZaIg">