<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/154756>154756</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            clang-tidy incorrect readability-identifier-naming
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            clang-tidy
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          joker-eph
      </td>
    </tr>
</table>

<pre>
    With clang-tidy built at current head and applying it on MLIR:

```
$ /bin/clang-tidy -p build mlir/lib/CAPI/Target/LLVMIR.cpp --checks=-*,readability-identifier-naming -fix -fix-errors
```

I get this diff:

```
diff --git a/mlir/lib/CAPI/Target/LLVMIR.cpp b/mlir/lib/CAPI/Target/LLVMIR.cpp
index 1c1912aec0f2..10c501c962c0 100644
--- a/mlir/lib/CAPI/Target/LLVMIR.cpp
+++ b/mlir/lib/CAPI/Target/LLVMIR.cpp
@@ -51,8 +51,8 @@ void mlirTypeFromLLVMIRTranslatorDestroy(
 
 MlirType mlirTypeFromLLVMIRTranslatorTranslateType(
     MlirTypeFromLLVMIRTranslator translator, LLVMTypeRef llvmType) {
-  LLVM::TypeFromLLVMIRTranslator *translator_ = unwrap(translator);
-  mlir::Type type = translator_->translateType(llvm::unwrap(llvmType));
+ LLVM::TypeFromLLVMIRTranslator *translator = unwrap(translator);
+ mlir::Type type = translator->translateType(llvm::unwrap(llvmType));
 return wrap(type);
 }
 
@@ -73,7 +73,7 @@ void mlirTypeToLLVMIRTranslatorDestroy(MlirTypeToLLVMIRTranslator translator) {
 LLVMTypeRef
 mlirTypeToLLVMIRTranslatorTranslateType(MlirTypeToLLVMIRTranslator translator,
                                         MlirType mlirType) {
- LLVM::TypeToLLVMIRTranslator *translator_ = unwrap(translator);
- llvm::Type *type = translator_->translateType(unwrap(mlirType));
+ LLVM::TypeToLLVMIRTranslator *translator = unwrap(translator);
+  llvm::Type *type = translator->translateType(unwrap(mlirType));
   return llvm::wrap(type);
 }
```

Which fails obviously:

```
mlir/lib/CAPI/Target/LLVMIR.cpp:54:35: error: redefinition of 'translator' with a different type: 'LLVM::TypeFromLLVMIRTranslator *' vs 'MlirTypeFromLLVMIRTranslator'
   54 |   LLVM::TypeFromLLVMIRTranslator *translator = unwrap(translator);
      | ^
```

</pre>
<img width="1" height="1" alt="" src="http://email.email.llvm.org/o/eJykVk2PozgQ_TWVS8mRMRCSAwc6PUgtdaRVq7VzXBljgmcIRrbJTP79ypCvyXaniRYR4shVr16qHq7i1qptK2UK8RPEzzPeu1qb9If-KQ2RXT0rdHlIvytXo2h4uyVOlQcsetU45A5Fb4xsHdaSl8jbEnnXNQfVblE51C1uXl_eIMyADveCHm-aAYsQWF6oFlh-hUy6AbzEXaMMsLxRBbB8nf31Aix_52YrHbD89fXvzcvbXHQdEiJqKX5aCJ8JsAzY2khe8kI1yh2IKmXrVKWkIS3feV6kUr-HB5HGaGNvedHsBbfSoauVxVJV1Yf0_QYSslUOObB8Ktliui3QTLWl_I2BCFYB41LQis3nARUxDcRqwQTFgNJFFAHNCCGP8Bjy_zTeD3KCiEJEkcQBsPUSgT2dVuPGXquxdu-HTuZG70bvd8Nb23CnzbO0zugDsCXQDP1nc7S-63ZaSW9wdPbX5o4PuvMS2Br9tjd9kxU2zX43Iq0QkiefQhwMfLXD7FNEYNkF9B-E8Bn79pfhHbDldbQVhEfQIbVnUHT-4d2uYAiE39zN__MER7cz_hXncwBfwEdpf8nag35N-3-wRiNdb1o8UThuj3uQPB-VcdJaEgJbJ15rp9UHWnvXnytt86nNHxI5SeFaKf7n5yFuVTkx0Pqk3inXf16Pa83-WfsPwj4s2EsJh6Def6Jkz7hXRO8I9Suyk2Q6je7DbBFPEr3g3xHrTQP5XitRY8VVY1EXe6V72xw-bCNTz90wiyMIszCGMMOhb_mFkaWsVKuc0i3qCoEl12lK8Jdv23zoYnJo0wP5MPOW004Nj7K33v7eQQssGZMWRwjJGh8_Sr8s9vgueHCIv91kcVamYbkKV3wm0yCJ42QZLMLFrE7lIkgquoziOBbLJV-KkoVJxLmgMoiDqpqplFEW0yULgpAmwWJe0iAJqyQqIrpaUb6CiModV83c62CuzXamrO1lGsRREi9mDS9kY4fZibHLFAOM-VnKpN6LFP3WQkQbZZ294DjlGpleTT6qFdoYKRzeHWBmvWnS2rnO-vyyHFi-Va7ui7nQO68lL9jxi3RG_5DCa2lgbYHlR-L7lP0bAAD__2eaGv4">