<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/152743>152743</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            [mlir] `DefaultValuedProp` is printed despite the property being equal
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            mlir
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          amd-eochoalo
      </td>
    </tr>
</table>

<pre>
    Hello, 

I am not sure if this is intended but I believe it is likely a possible bug.

the [MLIR documentation](https://mlir.llvm.org/docs/DefiningDialects/Operations/) states the following regarding `DefaultValuedAttr`:

> The generated operation printing function will not print default-valued attributes when the attribute value is equal to the default.

I believe the same will apply eventually to `DefaultValuedProp`. However, at the moment that is not the case. The `DefaultValuedProp` will be printed even if the property value is equal to the default one.

While this is likely not a huge issue, it may hinder some adoption of properties. Consider the following case:

1. I want to add a `DefaultValuedAttr` to one of the LLVM intrinsic operations which does not have a custom assembly format (this follows the convention in the LLVMIntrinsicsOp.td file)
2. I believe since `let usePropertiesForAttributes = 1;` then this `DefaultValuedAttr` will be instead stored as a property.
3. This property will now be printed when using `let usePropertiesForAttributes = 0` wouldn't.
4. Then I need to define a custom assembly format where there is no `prop-dict` but instead an `attr-dict` to force the `DefaultValuedAttr` to be kept as an attribute and not a property.
</pre>
<img width="1" height="1" alt="" src="http://email.email.llvm.org/o/eJyMVcFu4zgM_RrlQtSwlTiJDz6kkw0mQAczWCxmz7LF2NqRJa9EJ8jfLygnabtAiwEKNBDlRz6-R0rFaDqHWIvyWZT7hZqo96FWg35C3_ZeWb9ovL7WX9FaL-QXEPlO5LsjqAGcJ4hTQDAnoN5E4D9H6DRqaCaCIzRoDZ4RDHHQml9or6Bg9DGaxiI0U5fNiNQjiPL528vxT9C-nQZ0pMh4J8q9kNueaIxiuRPyIORhsCZk1p6HzIdOyIP2bRTysMeTccZ1e6MstsRH30cMCSamLyuIpAgjcLqTt9ZfjOsgYKeC5l9ine_xpCZLP5WdUO-IgljnnDmVKZZ_wF89QoeOgVGDv2eAMRhHDHKaXJtOLsba1KYUAj0jP50TNCiiYJqJy7n06FJNjzNIl7hr-O-kLJBP8RtEdpfh3mCORTXgnFKNo70CntHRpKy98tf_Z_Yj-FGs8wy--gueMbC4ihLQ4Ln7QL1KsjEBPm5VxCyx_wBrTt7gTBd1qmB2B59xp-j6OTHwDm_k_u6NxYexbt7hWhT0U8cIcUKu2hAM6gq9cRoDRD8gKO3HpIA_3RMbjBl88S4avvVef2b2kLjI4AgXxQ3woLQG9ZEr-IJ3yEkY7-Xl5zcegGBcNO2rMVhe0_agPc7N7NUZQUE7RfIDqBhxaOwVTj4MikDIbSI9lzdbtfWOxWRGxj2SHe-54vcxIw0nY1HISuQ7mb0ZvmhcmzSzSDBF_PFoyMGH3asJxXIPhVg-J2azIU38kPtda-MiodIQyQc2deT5vmnNSi7ZMia-6n8bistboyT_T_E2gb9RZ55K8JPVTshNmodV8qaDIzhEzdpo3gefdPrSY0ijE3D2OSfnOp-0aYkz8Ba7E1SOwzygjzB5hmrn8fvEJA3CLxwpNce9mXHl9M3Rj44tdL3U1bJSC6yLTblar9fVulj09Xqz3uRFXjVFpVVZVdttmRfrfLlR5arKN5uFqWUuy3ybb4tSVrLIVquqPamywaosthVKscpxUMY-NucijVBdlHKzWi6satDG9BJIyRtWSMlvQqj5_lMzdVGscmsixVcEMmTT65E-KPcfrobkgFlsjXE0hO-3QoMsfloJiynY-v3C7wz1U5O1fhDywMlv_57G4P_BloQ8JC685W90zrX8LwAA__92e1oS">