<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/151896>151896</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            [MLIR] custom<SymbolName> in Symbol's assemblyFormat generates call to non-member versions of parseSymbolName and printSymbolName
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            mlir
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          xushengj
      </td>
    </tr>
</table>

<pre>
    version: `llvmorg-20.1.8`

When I made the following Op definition: (`AssetDeclarationOp` has `Symbol` trait)
```
def ImageAssetOp : AssetDeclarationOp<"image_asset", []> {
  ...
  let assemblyFormat = "custom<SymbolName>($sym_name) $asset_id `,` $imageattrs attr-dict `:` type($result)";
}
```

Tablegen emits the following code in `cpp.inc` that calls non-member version of parseSymbolName and printSymbolName:
```
::mlir::ParseResult ImageAssetOp::parse(::mlir::OpAsmParser &parser, ::mlir::OperationState &result) {
  ::mlir::StringAttr sym_nameAttr;
  ...
  {
    auto odsResult = parseSymbolName(parser, sym_nameAttr);
    ...
  }
 ...
}
...
void ImageAssetOp::print(::mlir::OpAsmPrinter &_odsPrinter) {
 _odsPrinter << ' ';
  printSymbolName(_odsPrinter, *this, getSymNameAttr());
  ...
}
```

However, in `mlir/IR/OpImplementation.h`, they are member functions of `AsmParser` and `AsmPrinter`, respectively, which causes the compilation to fail. I currently use the following workaround: (i.e., define non-member versions of the functions)

```
namespace mlir::preppipe::PrepPipe {
llvm::ParseResult parseSymbolName(AsmParser &parser,
 StringAttr &result) {
  return parser.parseSymbolName(result);
}
void printSymbolName(AsmPrinter &printer, Operation *op,
 StringAttr symName) {
  printer.printSymbolName(symName);
}
} // end namespace mlir::preppipe::PrepPipe

#define GET_OP_CLASSES
#include "preppipe-mlir/Dialect/PrepPipe/IR/PrepPipeOps.cpp.inc"
```

</pre>
<img width="1" height="1" alt="" src="http://email.email.llvm.org/o/eJyMVt2O4jgTfRpzUyIKDn-54CIDzfchzQ6tZqS9RCYpEs86sWU79PL2q3JC8zvSSHQntsvHVXVOlSOck2WDuGCTb2yyGojWV9ou_m1dhU35a3DQxXlxQuukbliSAZvGSp1qbcshj6NRNGfTmMUZi7O_K2xgA7UoEHyFcNRK6U_ZlLA1UOBRNtJfQDhty5xDv8JcCStoZWvYNIZKODpkd64PWtGEt0J6xlM6ZRr3vzgr8AibWpQYYLYGCPgFZLJknEsy3AtaZZwzvoQuXJa8AZt9Y3EGEEVReCr0QJb1QZ3X2tbCA0tWwDjPW-d1zZJl59wPUSNL3igYPnbnet_QBE-B8XE4ai8LCoXxJcXB-Di4Iby3Duj_sJC5DxZJFiI9G-zQLLpWhaA5Zwn5x2arhwSwOPspDgpLbABr6d1D1nNdIMiG8HNjItnk4YxKeMiFUg4a3QxrrA9ooScY9BGMsA6vAYJoCjBWNv426OzRl4R-tZK2e3snkI8QxB1J3Wo4ggJ92LU1mavDVguMT4OZDWQ9GWLH784Lj2T7lbAvOh_37LyVTZl5b-HCFQ267F7Zv2wHEK3XoAvXh0EaeMgN4_Orj3egPL3g3iITg_2wG3TvJy2LV1mipP82S7TYpWmvC9cPb-K_mQWqgWQJjM_o7-LZI6l8fodE9pmvpKPXEsnyx1d48yDN9D55LyX6f_2Jpw6v02IIhK83H4yvt2ZTG4U1Nj7QGVVduZCSzyAsQq_PY9vkZOBIoaF19DohSZNC-7ne-Q7EojOYe3lCdabxZyXzCnLROuxqJde1kSqcDF7DUUgVwQby1lpsvDpD6x5b2ae2_wir26bo-5iMMCLw0ODwRU0FlwPIJYa-l92niqTjjMgRrkwbi8ZIg31NWTTv0mDPMHXh52J7VujrkiLabiriZQVZ9K1tOkgbPSNfm9RNhwpifpbWvWTNVWRfpUxy0-bZNdfp7taxfnv0fMzV-K5rzqh9rxlfAzYF_Hmqe5p40rP7v7ef--37fvk92-3edt2SbHLVFtSE-AVk2Gt8JYXC3DO-_gLshX8Zb42LLs2Z8wdJDIpFUqRJKga4GM0mYz6bzNJkUC2mKaZczPIknohJXoj5tEiSYnTI57NiKkbpQC54zCfxPB7HfJxOkqjgeIyxmCf5dCREcmDjGGuSO6ko0rYcSOdaXIwmo3k6HShxQOXCJwHnXTCcPg7sguyHh7Z0bBwr6by7InjpVfiM-Ov75oNNVvD6uqQ20F_ufOYeb9oSG9IDunBHUVX-pqL-4JoatFYtKu-NI1YD_6X0VXuIcl0zvg4V1D2GxupfHVUhEY7xdZ-L04L_FwAA__-Yo-ED">