<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Issue</th>
<td>
<a href=https://github.com/llvm/llvm-project/issues/143234>143234</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>
[flang] Use of precompiled headers leads to undetected missing includes
</td>
</tr>
<tr>
<th>Labels</th>
<td>
flang
</td>
</tr>
<tr>
<th>Assignees</th>
<td>
</td>
</tr>
<tr>
<th>Reporter</th>
<td>
mgorny
</td>
</tr>
</table>
<pre>
I do realize that @mrkajetanp did introduce precompiled headers to reduce memory usage on my request in #131137, but looks like we missed a major problem with them: they hide missing includes, so now buildbots remain green when a code with missing includes is committed, but the end user builds without PCH fail.
Perhaps we should disable PCH on (some of the) buildbots via `-DCMAKE_DISABLE_PRECOMPILE_HEADERS=ON` to catch issues.
See #143196
</pre>
<img width="1" height="1" alt="" src="http://email.email.llvm.org/o/eJxskktv2zAQhH8NdVnEkEhZsg46OH4gQZPGSNBzQIkrkQkfKh8x3F9fSE7Rou1pD9oZzX4cHoIaLWJL1rdkvc94itL51ozO20vWOXFp70E48Mi1-oEQJY9Aytz4d_6GkdsJhBKgbPROpB5h8tg7MymNAiRygT5AnPXLV4PG-QukwEcEZ8FcwOP3hCGCskAoK1hRsJrQHXQpgnbuPYBW7whnBKNCQAEcDH9zHibvOo0GzipKiBINYdt5XkAqcd1WdgRle50EhtkzOLDuDF1SWnQuBvBouLIwekQLZ4kWOPRO4NX0bwtQAXpnjIoRxa-MUSKgFZAC-qtzWNQuRTjt7mDgSq9IviX59oRe8inMtwTpkhYgVOCdxmXRzQA2wRkEN8y2hDZ_RP1QHEiV3-x3j9svh9f9_cv29uHweno-7J4eT_cPh9e7w3Z_eH4hbP_0lVT5jL3nsZegQkgYPkO8IC6gS1Y0VSZaJhrW8Azboi4bWld1yTLZdoyzAtebig8D3TS0rBqs6k3T5bQZRMUz1dKcrvMqr_OqoJStOGvqes34Zr1B2pQDKfMZrl5p_WFWzo_ZEqMtSkZZmWneoQ5L7SgdNLcjoXRuoG9nwU2XxkDKXKsQw2-LqKJeunpVrPfwLSy4_lc7jVws5UtWYMQ-ovjnSbPkdStjnAJhW0KPhB5HFWXqVr0zhB7nP3-Om8m7N-wjoccrUEKPn8d8tPRnAAAA__9qUBdL">