<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/137868>137868</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            [HLSL] Report diagnostics for implicit resource bindings that cannot be assigned
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            HLSL
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          hekota
      </td>
    </tr>
</table>

<pre>
    Report diagnostics for implicit resource bindings that cannot be assigned, such as:

```
RWBuffer<float> A : register(u1);
RWBuffer<float> B[];     // gets u6 (unbounded range)
RWBuffer<float> C : register(u5);
RWBuffer<float> D[4];    // error - does not fit in the remaining descriptor ranges in space0 

[numthreads(4,1,1)]
void main() {
  A[0] = D[2][0] + C[0] + B[10][0];
}
```
https://godbolt.org/z/6bYoG599P

Expected:

```<source>:4:1: error: resource D could not be allocated```

The error should be reported from `DXILPostOptimizationValidation` pass which can take the time and can depend on all completed resource analyses and/or debug info to lookup the resource variable name.

Implicit bindings are assigned by the `DXILResourceImplicitBinding` pass fairly early in the LLVM pipeline. It replaces `dx.resource.handlefromimplicitbinding` calls with `dx.resource.handlefrombinding` calls for all resources that can be allocated (= assigned a binding).

If a binding cannot be assigned, the pass will leave the `dx.resource.handlefromimplicitbinding` call associated with the resource in the IR to be picked up by the `DXILPostOptimizationValidation` pass for diagnostic. If there are no such resources (= all resources have binding), the `DXILResourceImplicitBinding` pass clear the `ContainsImplicitBindings` flag on `DXILResourceBindingAnalysis`.
</pre>
<img width="1" height="1" alt="" src="http://email.email.llvm.org/o/eJysVVlv4zYQ_jX0yyCGTB22HvTgI24DpOgiLbbtI0WOJDY0KZBUdrO_vhgd8Sa7KbZADfkiZr6Z75uDIgTdWsSK5QeWn1ZiiJ3zVYePLopV7dRz9YC98xGUFq11IWoZoHEe9KU3WuoIHoMbvESotVXatgFiJyJIYa2LUCPMMRTjRwiD7EAElu5ZMj5FMj_J_uGPw9A06Fl6bIwTkaW3sAeW7sFjq0NEz_hu2DBesvTwjv1h4sHSA9CL8TPjZ2gxBhgKIH9bu8EqVOCFbZHAvo90_CZy_q-RTyw_ZNfQc2T03nm4AeUwAOnR6AjaQuwQPF6Ettq2oDBIr_vo_JRVIJPQC4kJzDrlBztcYudRqMD4LmP8uJneJQVN9k9OKyBAxneMl8C2lCkAuSYsPwFLT2OSnOyXM36A49d_SL9NcrWY-LLt6U2tuhj7sYojzdap2pm4dr5l_PyF8XNR_-V-ysvyw5T-7eceZUT1nbqnx6l9WHrL0n3G0v2GhB-Fmyowt9cJpBuMgqWrjHFSEOZXabFk_3uHs-qhG-1rUppaGBU03l2AFcnpz7v7Dy7EX_uoL_qLiNrZj8JoNf5iRQK9CAE-dVp21MkQxSOORYv6giCsGk8V9mgVOEvZgHSX3iCFeclZWGGeAwbyYPzsPCishxa0bRxEB8a5x6Gfu2H2eRJei9ogWHHB9UTqbhm2lxkT_jpYUD-PEDOxhxlpcTpMPi-sGqG9eQYU9Dn34v39x1-g1z0abXENdzTWvRESA6Gqz-slvXUnrDJIQi4boL7iS2FMgE86du-7fWNO24T0W2yvC-RVnWl6qYdfWItFDcbLRafmevrOBiK2U3G1MWBQPOEi3n-iSaBO6jGzkfCrIs6y3j1QlWuEXstHVDD0b2r1A01I8lyX7xruGgKg8nsE66aVetVuUemVoB2xvKq16PCDDSMNCr84HJ2NQtvwxjiQdWNES9PwBnc22Y_DoMlyvVJVqsq0FCusNtssL_O8TLJVV9V8J7DBhPNNvROyKBu-E7sizbYFNrncrHTFE54nGS83ZZYn2bop8u02F6IodkVW7jjLElqsZm3M04VW0kqHMGC1Sbe7YrcyokYTxvuO85_vf7tnnDbiyldkf1MPbWBZYnSI4YoQdTTjHTk65Cf43y7F1eBN9Wab6tgN9Vq6C-NnSmH-uum9-xtlZPw8MgqMn2dSTxX_JwAA__8KgYoS">