<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/132182>132182</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            [lldb] coerce the breakpoint condition expression into a bool
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            new issue
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          k4lizen
      </td>
    </tr>
</table>

<pre>
    Currently, when a user sets an expression as a breakpoint condition, the expression can evaluate to an arbitrary type and that then gets interpreted into a boolean with the IsLogicalTrue
https://github.com/llvm/llvm-project/blob/main/lldb/source/Breakpoint/BreakpointLocation.cpp#L310 
call. It would be smarter to wrap the condition into a `(bool)(..)` so that that conversion is handed off to the underlying compiler/type system. 

Doing this would fix https://github.com/llvm/llvm-project/issues/132177 as the expression parser would return a clean error. It would also help detect errors like https://github.com/llvm/llvm-project/issues/132179 .

Also, if we take the example from https://github.com/llvm/llvm-project/issues/132179 , if we set the breakpoint condition to just `bol`, lldb will always return true due to https://github.com/llvm/llvm-project/issues/132177 (or error out if that is fixed) whereas a user might expect that the `operator bool()` will be called.

Importantly, wrapping the condition text into just ``(bool)(..)`` doesn't work because the condition can contain multiple statements like `st1; st2; expr`, but it would work if wrapped into a statement expression (https://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html) which is supported by clang. So wrapping it into a `"(bool)({  ...  ;})"` should be fine (at least for C/C++).
</pre>
<img width="1" height="1" alt="" src="http://email.email.llvm.org/o/eJykVd1uqzgQfhpzMzqImBLIBRdNu0hH6t3ZFzBmCD4xNrKHptmnX42TtGm152JVqZJLbM_P9zNWMZqDQ2xFtRfVc6ZWmnxojw_W_IMu6_1wbp_WENCRPQv5BKcJHShYIwaISBGUA3xbAsZovAMVQUEfUB0XbxyB9m4wZLzjuzTh_VnNV1-VXRUhkOdIKvSGggpnoPOCoNwANCnimw4OnM44wrAEJBz4f8_pvLeoHJwMTSnHz_jiD0Yr-3dYURSPE9ESRfkoZCdkdzA0rX2u_SxkZ-3rbfmxBP8bNQnZ9db3QnazMi5tDvwV_Ro0Ctnt39v79PHiteJOc70sQpYv5aYAUTxqZW0OPwlOfrUD9AhxVoEwcMunoJZU8jtOt6bEthCy4daE3AnZ5Dmv2wKiv0GiEryvGBKaJsKk3IAD-HHk2Bx2dQMGezbuANrPi7EYhOwStvEcCeecSxTF47PnMzSZeK1zNG_wv3EzMa4Yhew2pdzUNavhC-eLCqycS46AtAZWk078YQg-3EGlbPQwoV1gQEJNlwMRrDnid2vbQX5p_NFGz9o0I5wQSB3xWrKaF4swBj9_P9dHgohJzP9pESbt9xqJue-9TQp4AlYfnIy1oOxJneMNNQorwrAm53ybKCEbHy74gl-Ji036MpGFgIOQO3Z-wOTvZP7ZHCZiapmZm0m5dL9gUOQDXMTbXHWbWugR2A84XNH_OS8-kHofLkEty0WI95YgfKOLL27w_MkdnGjwGJ2QNcsoHKFHrdaIX0Ly7NHekTIO5tWSYbIjKcIZHV01JrZFpI0o9xBJ8sJCvtLSM0o3paZETDDX_zGY3uPdO0DI5gtdWucHt-Y-HITsvLPG4eB1vGwJ2f26hfnx19sSYj7RbC-EGD0xRXFdGEYcoD-DtsodcvjlP9A09GmqyE_QiXoPkOc5gCj3on5Ov8o0aabbxBqNQy5cEVhUkWD0AZ6E7J6E3Ke_XZ4NbTnsyp3KsN3UD_Jh28imyqYW60bqohq2zTg2SlVlresSi7qsyqIo5TYzrSxkVZSy2BRVU1T5Tm13u3Eshnrb95vNTjwUOCtjc1Yx45Ql_bYs3kZmVvVoY3rBpHR4grTLTVTPWWiT9Pv1EMVDYU2k-BGGDNn09KURXz2D9hg0_tmhdzzePT7ZGmz7PQ82Mntt5b8BAAD__0-8h9k">