<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Issue</th>
<td>
<a href=https://github.com/llvm/llvm-project/issues/129940>129940</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>
[HLSL] Root Signature semantic analysis - Bounded Parameter checks
</td>
</tr>
<tr>
<th>Labels</th>
<td>
HLSL
</td>
</tr>
<tr>
<th>Assignees</th>
<td>
inbelic
</td>
</tr>
<tr>
<th>Reporter</th>
<td>
inbelic
</td>
</tr>
</table>
<pre>
This issue handles the additional semantic analysis of the parsed `HLSLRootSignature` attribute. This includes generating applicable diagnostics.
The relevant validations that this issue must implement are:
- [ ] Ensure valid values of `DESCRIPTOR_RANGE_FLAGS` for the `Sampler` descriptor table clause
- [ ] Ensure that listed parameters of `StaticSampler` are bounded correctly
- [ ] Validate that the `space` parameter is not in the invalid range of `0xFFFFFFF0` to `0xFFFFFFFF`
AC:
- [ ] Update `ParseHLSLRootSignature` defined in #119011 to implement semantic validation of `HLSLRootSignature`
- [ ] Update `handleHLSLRootSignature` to implement semantic validation of `HLSLRootSignature` in `SemaHLSL.cpp`
- [ ] Add thorough testing of correct diagnostics into `clang/unittests/Sema/ParseHLSLRootSignatureTest.cpp`
- [ ] Add tests for some samples to ensure diagnostics are displayed correctly from HLSL input in `AST/HLSL/RootSignatures-AST.hlsl`
</pre>
<img width="1" height="1" alt="" src="http://email.email.llvm.org/o/eJyklEtv6zYThn8NvRnYoCjLl4UWzkl0vg8I2iB2uz0YkSOJLUUKJBU0_74g5dwOfFb1woZH4rzPOxdiCLq3RDWr7pgQ2rZktGRCsOp-hXMcnK-vwVXr1Gt9GXQAHcJMMKBVhgLEgQCV0lE7iwYCjWijloAWzWvQAVyX35nQB1LAdvx_j-fHZ-fiWfcW4-yJ7ThgjF63c6QNLCJWmllRgJ4seYza9oDTZLTE1hAojb11IWoZNoyfGD9dBgJPhl7QRnhBoxUmpASIEeIH-DiHCHqcDI1kI6AnVqYEa2DVHbDqHh5smD0tSdL3TNkF2_H7h_O35_8_XX5__vF8-u37w4_m8fT9nPg757NNtuNnTMl9iioK0usppoeZWxqcA91Sy5hGh0gq1QpHiuTfdM8Ro5afEqMnaN1sFSmQznuS0bx-SfvnUgJ685_RwoQyl_tdAXQA6yJom9_RdnHt0fZ0Fef_NMuHp5PRfYk1KbZ04PTt50L-MWUCtuNPqfs3G6-o05ZUAmCiLIojL4ok8tGh95H66OqV7FbCXwAs43qT4D-IZeodP9OI6fFGTtPPCCelIC2Sm_sBIoU8ya5769rnSQZtl-pKg7ZnopmtjulIYKJJGkw0twt5oRB_KZ4S5PkMbiQIeYhCck3L5H0mwPw_TAZfP08WdN6NkGRB22mOV9-n84WJJoWZaL4AhfXpfNkMJhi24ytVl-pYHnFFdbHfFqLgx-KwGupyW-6w2B9pT91hdyipVELgviq6Sm3LtlvpWnBR8ZJXotgW1WHTbrtOlp0si_1RHbqObTmNqM3GmJdx43y_ykteF-J43PKVwZZMuF5vC2e-23yd3l-3cx_YlqetCx8Zoo4mX4n5QHUPyRm8W7txxa3h7rqLT-97JQeSf4fV7E09xDiFtBuiYaLpdRzmdiPdyESTRK8_68m7v0hGJprsITX9auOlFv8GAAD__5gy3_U">