<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Issue</th>
<td>
<a href=https://github.com/llvm/llvm-project/issues/129122>129122</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>
Mislink with ICF and multi-instruction GOT entry references
</td>
</tr>
<tr>
<th>Labels</th>
<td>
new issue
</td>
</tr>
<tr>
<th>Assignees</th>
<td>
</td>
</tr>
<tr>
<th>Reporter</th>
<td>
pcc
</td>
</tr>
</table>
<pre>
With the attached reproducer, the `f2_*` functions containing the second half of a two-instruction GOT entry reference are ICF'd, but the `f1_*` functions containing the first half of the reference are not. Because the two functions refer to different GOT entries, about half of the `f1_*` functions end up loading from the wrong GOT entry (or potentially from an address outside the GOT entirely).
```
clang --target=aarch64-linux -c icf-bug.s
ld.lld icf-bug.o --icf=all
objdump -d
```
[...]
```
00000000002128e4 <f1_504>:
2128e4: d0000080 adrp x0, 224000 <f1_1000+0xffdc>
2128e8: d2803f01 mov x1, #0x1f8 // #504
2128ec: 17fffa17 b 211148 <f2_0>
00000000002128f0 <f1_505>:
2128f0: d0000080 adrp x0, 224000 <f1_1000+0xffdc>
2128f4: d2803f21 mov x1, #0x1f9 // #505
2128f8: 17fffa14 b 211148 <f2_0>
00000000002128fc <f1_506>:
2128fc: f0000080 adrp x0, 225000 <f1_1000+0x10fdc>
212900: d2803f41 mov x1, #0x1fa // #506
212904: 17fffa11 b 211148 <f2_0>
0000000000212908 <f1_507>:
212908: f0000080 adrp x0, 225000 <f1_1000+0x10fdc>
21290c: d2803f61 mov x1, #0x1fb // #507
212910: 17fffa0e b 211148 <f2_0>
```
[icf-bug.s.txt](https://github.com/user-attachments/files/19016403/icf-bug.s.txt)
</pre>
<img width="1" height="1" alt="" src="http://email.email.llvm.org/o/eJyslU1v6zYThX8NvRlIIEcflhZaOMnrF3dRdFOgy4Dih81bmjRIKnH-fUHZVWzn5qYtSgQITHLOnPMI4PAYzc4pNZDmgTRPKz6lvQ_DUYjV6OXb8LtJe0h7BTwlLvZKQlDH4OUkVCD4OB-Rlmp8JrghLQU9OZGMdxGEd4kbZ9xuvhWV8E7CnlsNXgOH9OoL42IK01wA___1N1AuhTcISqugnFDAg4Jvj1uCa5m7jVNaOrIvO2oTYloa5p1bYedTCQ9K8Cmq-Ti9-iu1-TIkD9LouSwtFo2K2Q4f_XTb4BNjykmYjmA9l9mcDv4wX38N3u2ughPsfICjT8olw619O1_lDriUQcUIfkrRyLPdS50Jyr4R7EtCc9vLH90Iy90OiiLxsFOJVE-cB7Fv68IaN50ACgFG6GKcdmUkdGNlaa1ctjwUhRE6l1lL6MaP3-V0OEIh79qQ5qEsS9I83e3TZSHDTtVAqkfNnhtak-p_pNoQugE4H5FqA-cl54KOApfhmDdONINGrCmlFwVGKSX4QE9aS5G1FqHuSgg7WmnKLj_h4F_gxLIWwYqemO7gh4vgluA2X8pGF2XxrszWWmvO1n9VjICMsbqb3eEzPTv6AEDTBUBzB0DT_wiAru8B4OcA-q8BNO_K3QcA9T8FIBYA7T2AK7z6MwDNDwAwekugp_SeQM3m6LPSdXz-dfz2Xbb-EJ_BeNn4O-l72i3p17fpezqzXXJf1r-LP4M8B29vPv2H_OPX-deLLpuxnpNT9f7hfwLg-oWYH4nlrSnTKeXnArt9SseYUcxNdybtp7EU_kBwO0UVivPMOSiXIsGtNjY_u1vWU9bWtCK4vdXEfiWHSvZVz1dqYOuatj2re7baD0zUnW44W4-1rLSka1E1rB37XtFaVFKvzIAUG4q4RoZ1w0psehx1j03fopJVR2qqDtzY0tqXQ-nDbmVinNSQ6SCuLB-VjfMURXTqFeZTgpiHahhyUXYaSU2tiSm-yySTrBp-MdEa9we85nn77XEL3Ek4TDaZr2ZkXE3BDj9BmTtd_hXH4L8rkTK67G_GeQ7wMuCfAQAA__-C0Sv6">