<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Issue</th>
<td>
<a href=https://github.com/llvm/llvm-project/issues/121573>121573</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>
Revisit the llvm/test/ExecutionEngine/JITLink/x86-64/COFF_comdat_weak_plus_strong.s test
</td>
</tr>
<tr>
<th>Labels</th>
<td>
new issue
</td>
</tr>
<tr>
<th>Assignees</th>
<td>
</td>
</tr>
<tr>
<th>Reporter</th>
<td>
hokein
</td>
</tr>
</table>
<pre>
I discovered an error in this test, and fixed it in https://github.com/llvm/llvm-project/commit/e576c5bed79f8a9528391756c8475cc3a6276adf.
However, this test doesn't seem to test anything -- I made some arbitrary changes (e.g. `llvm-jitlink` to `llvm-not-valid` on Line 9), the test was still passed. It is a little hard to understand the purpose of this test with the combination of `XFAIL:* ` and `not`.
@sunho, you're the author of this test, can you take a look at this test?
</pre>
<img width="1" height="1" alt="" src="http://email.email.llvm.org/o/eJyUU02vpDYQ_DXm0hoE5vvAYbJZlImeFCnKIbenxm7AO2CP7Gbmzb-PzOwmL8c9Ad1Nuaq6jCGY2RL1ovpFVL8muPPifL-4KxmbjE4_-wtoE5S7kycNaIG8dx6MBV5MAKbAQn4BtBom80EaDMfmwnwLojgLOQg5zIaXfUyV24Qc1vX-43G6efeNFAs5KLdtJr5Q1dSqGkk33dRiV8m26PKmqlVbNpVSBdayqVFPqcjOIjv_5h50Jx85_EsItKNghWwYAtEG7F5ltE9ejJ3hdIILbKgJgtsI0I-GPfonqAXtTAGEbCmdUxB1dvD8Zng19irqLIL9qFrHpzuuRse6s_BmLEEnZPdiQ69THxggsFlXuGEIpFO4MJgACKthXgkW9DrC7laTDxytjD_fdn9zgcBNn5Q9DC9HV7ltNBbZOBsnRJ39PZwvb4fl5_h5rETUmXUs6iyFl12izMJuFxcZPt0uZOPpwHtt_n-HxRmFNs4B45UiY-eugPxpphgS3Re6KzpMqM-bourysijbZOlVN0kiVJnEZsqnnKauxSJTlVJUIMrE9DKTVZZnRV7KqmxTrauKajVq2bRjXdWizGhDs6bR7tT5OTEh7NTnMq-aIllxpDUc2ZXS0gOOrpAyRtn3x47GfQ6izFYTOPwHw4ZX6v-kuwmGD_3fU_nSPXz9ILVHb7_a2VgScvj98tdbTIAcPtr6VJdCDl_-GIZ35TaN_P4gvL7f1j28B_bOzunLnmT3a__Td-GQEYQcvuu89_KfAAAA__-41TKS">