<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/120630>120630</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            [DirectX] Transform fast math flags to LLVM 3.7 for bitcode writer
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            backend:DirectX
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          llvm-beanz
      </td>
    </tr>
</table>

<pre>
    The DXIL bitcode writer is currently encoding modern LLVM fast math flags instead of LLVM 3.7's equivalent.  The patch below is probably a starting point, but is likely not everything that needs to change to address this problem.

```diff
diff --git a/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp b/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp
index 45aadac86194..4ea31dde3e00 100644
--- a/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp
+++ b/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp
@@ -749,20 +749,14 @@ uint64_t DXILBitcodeWriter::getOptimizationFlags(const Value *V) {
     if (PEO->isExact())
       Flags |= 1 << bitc::PEO_EXACT;
   } else if (const auto *FPMO = dyn_cast<FPMathOperator>(V)) {
-    if (FPMO->hasAllowReassoc())
-      Flags |= bitc::AllowReassoc;
+    if (FPMO->hasAllowReassoc() || FPMO->hasAllowContract())
+      Flags |= bitc::UnsafeAlgebra;
     if (FPMO->hasNoNaNs())
       Flags |= bitc::NoNaNs;
     if (FPMO->hasNoInfs())
       Flags |= bitc::NoInfs;
 if (FPMO->hasNoSignedZeros())
       Flags |= bitc::NoSignedZeros;
- if (FPMO->hasAllowReciprocal())
-      Flags |= bitc::AllowReciprocal;
- if (FPMO->hasAllowContract())
-      Flags |= bitc::AllowContract;
-    if (FPMO->hasApproxFunc())
-      Flags |= bitc::ApproxFunc;
   }

   return Flags;
 
```
</pre>
<img width="1" height="1" alt="" src="http://email.email.llvm.org/o/eJysld9v4zYMx_8a5YVIYEuOEz_kwU1i4ID-wtZ1xV4K2WZs7RTJk-i2ub9-UOxrs16vuwItBFiNyQ-_ImVSeq8ag7hi8zM230xkT611K60f9tMSpfk2KW19WN20CJu7L-dQKqpsjfDoFKED5aHqnUND-gBoKlsr08De1ugMnJ_fXsBOeoK9pBZ2WjYelPGEsga7G96L2YLxhQf8p1cPUqOhGUAI10mqWihR28cQpnO2lKU-gARP0lGI01lliPE1lD0FG62-oj6AsQT4gO5AbbCiVhIYxNoDWahaaRoMO1nXDr0Hake8xv2MRXlYaTSsWu12LMrDA6bTRhFIxouQnfBQJePFjXQNEuPFRjms6C7s7r6c_3lM0PjP2ZC14bdZ1XVQfgqGRbkyNT5BMpeyltUyjbNkNktQiriuUWAUQRxFaZKwKJ9Op5-kPmSInw3r807CkoglEUwXScb4mkfA-NmwjxMYX_bKUJrcE_wAYSJnIm-QrjpSe_VNkrKmCFeO8WVljSe4lbpHYDy_ZTwDtjhjUQ7hT-2A8eX19mrKxFb57ZOsiPEl41lYoxHAkQZssWZiAzEwsWZiffwihuDX26v77V2-vmFiRLPFBlB7HCMMMmRPNqgori-uIKDqg7mvpCcm1sX1haT2qkMnyTomtowvbwcdo-Dpi-AACIpb6XOt7eNvKL231any6RvKXwT_x-uoORT01_hH2mINr43W1pB7lb-R-lMdfxgvd5jrBksnn5P3hoxLeykv_f-V5gU82r9L_GJ2HyIe7QfiG7TfQzet_0JnPwQ9dRNDmX9Wg0p1zlZSf7jMz47vBnirfr-Af3YT71zSrnP2qejNR67oi8_JRzV0aQBwSL0zg_NocNq-J_VK1JnI5ARX8UIkqVjGcTppV1mZoiizVCzSKk2SKFlmieDzUtRJnGG0nKgVj3gS8ziLs_k8TmeikqWoMo6LuahFIlgS4V4qPQu9b2ZdM1He97iKeZSKaKJlidofpyrnpay-oqmZyJ9bIg_D9vuc7RvPkkgrT_4FR4r0cSx_95lv4MZJ43fW7X8Yq2SfxynsrHs1pye906uWqPMhq7xgvGgUtX05q-z-pH8HNZ2zf2Oof3E8kGe8GM_0sOL_BgAA__-srHEn">