<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/119281>119281</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            [libc] re-enable warnings for tests
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            libc
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          nickdesaulniers
      </td>
    </tr>
</table>

<pre>
    Link: #81917
Link: #119054

https://github.com/llvm/llvm-project/commit/d0c2c0ab6d7e52ae52fdf73b843cad607f5a85e6 split the compiler flags between the tests and object files. #119054 fixes warnings that crept in because these warnings we not re-enabled (d0c2c0ab6d7e52ae52fdf73b843cad607f5a85e6 makes it sounds like they were never enabled?) Either way, we should work towards getting these turned back on, such that downstream users with such testing aren't finding such bugs downstream; instead we are upstream.

Specifically, there are many commented out warning diagnostic flags in libc/cmake/modules/LLVMLibCCompileOptionRules.cmake. We should comment those back in, and fix the existing issues.
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJyUU8GOrDYQ_BpzaT0EZhjgwGHevsxpo0iJlJyN3UBnjD1ym2Xn7yPDvMwekxPI7e4qV1cpZpocYi_q76L-kak1zj70jvTNIKvVOsLA2eDNo38ndxPVBYSs2rIrG1FcvhyVZVfUJ1FcRHGZY7yzqC5CXoW8ThTndci1X4S8Wvvx8_PtHvzfqKOQV-2XhdKPKbTUhRrOpsFaKqzlaMamGtpTpZU5F81Yq7bGM_DdUoQ4I2i_3MligNGqiWHAuCG6vRSRI4NyBvyQkGAki5y_6MJIn8iwqeDITQxxVhF0wHsEcjCgVitjGsX4urQhOB8h4Dd0arBoQMj2PxNf1A0ZKAL71RkGS7cd4QEbBgSHHxjgOVhUVyE7-IXijAE29RDyLcHz7FdrYPPhBtFvKhiGCWMkNz3JxjU4NDAofQPvUhuvej7eZ_zmOAZUC6yMgWGjOD_ryPsQFdAJ2STBnEkHe3VYJ_7SLarvQI4jKpNIqYCw3o9SfvjgjztqGkkra3fq6RnHxUW5R9rcgi6iAb_Gn_qCITU5z5H0c6PkwNKgk02SeEJeF29Wiyzk9f39z1_faXh7O0zw2z2Sd7-nYr5fzuGvf-V6wkGcPeMhDe3SJIOM9LlbBj_pkICYV-Q8M31luqpTGfZlU1VNe2qqJpt7NZ6HWpmmxvbcleehbqu26IpCK3lGXVUZ9bKQp1IWnZS1LJv8VFZl1ZpTiziUQ9mIU4GLIpunMOQ-TNmO2ZdlJ9sys2pAy3swpTwEkCmiod_Dk5YhToUljvyaECnaPcx7Q_3j5dKXf0cfjmRka7D9_87qIYyQ1yfPj17-EwAA__-RDW6R">