<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/119184>119184</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            [Clang-CL][DXC] Should we expose `-fdiagnostics-color=` to clang-cl / clang-dxc?
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            clang-cl,
            HLSL
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          Maetveis
      </td>
    </tr>
</table>

<pre>
    Apologies if the `HLSL` tag is not appropriate I did not find one for the `dxc` driver.

Recently while exposing more options to the Fortran `flang` driver, some options were accidentally exposed to `clang-cl` too. Among them is `-fdiagnostics-color=`. Note that `-fcolor-diagnostics` and `-fno-color-diagnostics` are already allowed for both.
`-fdiagnostics-color=` allows one additional value `auto` which roughly means only use colors if the output is a terminal. This is also the default value of nothing is specified therefore, `-fdiagnostics-color=` is mainly useful to override an earlier `-f(no)?-color-diagnostics` / `-fdiagnostics-color=` option.

In #118640 I am looking to disable to flag again, mostly to keep the PR a clean fix and not introduce new features, but
personally I don't see a reason why this option shouldn't be exposed to `clang-cl` and `clang-dxc`. If we do we should definitely add test however.

</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJx8VE2PozgT_jXOpZQITKDDgUOmW9HbUr-r1cwe9lrgArxjXMguks6_XxnS03sY9SVBdtXjej5sjNEOnqhR5TdVvuxwkZFD838kuZKNu5bNvTnP7HiwFMH2ICOBqrL_vf14U1UGggPYCJ4FcJ4Dz8GiELyCsWZd7a03wJ6g5_DRbN671GuCvVI4qOyssvN36siLu8NttI6A3meO1g8wcSDgWSz7CMIrxIWDBPQJqnfoh08wpZ8h8vTZcaNAgF1nDXlB5-4bMpmEpaqsS_37zq1cmA9wntgP6ZQp8VJVtu-NxcFzFNvFfceOgypeVJUd4A8WAhlRtrp1b_-f6gSK3my7nve_L0gDukBo7oDO8Y3MqlXLMq7afDHC1hBXfdEYmzijgyu6ZRUaF-FUdhttN0LgZRjdHSZCn3rcHZZIsOL98pYXmRdJ3BGEwmQ9ugP8Ndq4rrm4WWCox8XJ4yjuk9dj8stGiDN1trdJ45EC9Rwo-fIlERthQvsYqV9csoevFII1BOiBMDhLYQNR-uRZ6VoVl99rqvTl6-O2eDyi9-pB6SLPT9Uxg1fACRzzz0RGGIyN2DpKn73DAXBA6xOdiWOKqzD8JJpXUf78DgidI_TQ2_fV-nQFrJfAZukIPN2gJ5QlUEwY7SIqO88UYvLN3dO9Ya_0k0AkAoRAGNnDbbyDJAu2uSGOvDizFbb0RaQf6duWtmt3gNcebgSG0--GlOy03gq5e8oRCEWBkW_0uJ870xSmLmrcUZM_FcVTUZbH025s8qx8qk512x9zbOtKH7NTXZTFqWrLujJY7myjM33MdVZnda716XCk6kh59VQQUVcWWh0zmtC6g3PX6cBh2NkYF2ryvM5Px53DllxcnyetfzHTWulnpfX6CmmdXq7QJIB9uwxRHTNno8RPSLHi1jfueUV4flPliyq_vfz9rMoX-LFpcPsQ8uvoCMPHHGvOPrUtLrsluGYUmaMqzkpflL4MVsalPXQ8KX1JAz3-9nPgf6gTpS8r4aj05cH52uh_AwAA__8Sotw1">