<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/107017>107017</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            [v18.1.8] clang-format: git integration doesn't work on Windows if the install path contains spaces
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            clang-format
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          jeliebig
      </td>
    </tr>
</table>

<pre>
    Currently the git integration for clang-format doesn't work on Windows if LLVM was installed to a path which contains spaces (like `C:/Program Files/LLVM` for example`).

This can be verified by either executing `git-clang-format` from cmd or using a simple pre-commit hook which executes `git clang-format`:

Example `pre-commit` hook:

```sh
#!/bin/sh

exec git clang-format -v
```

The actual script that gets executed in the end is located at `C:/Program Files/LLVM/bin/git-clang-format.bat` and contains the following code:

```bat
py -3 %~pn0 %*
```

I needed to look up what the modifiers `~pn` were actually doing, but after finding [this helpful website](https://ss64.com/nt/syntax-args.html) it turns out we only need to add some quotes around the first argument to fix this issue.

The usage of `~` expands the argument, but also removes any surrounding quotes, so we need to add them back manually.

The fixed script looks like this:

```bat
py -3 "%~pn0" %*
```


---

I have never contributed to LLVM before and don't have enough time to fix this issue myself even though it's an easy one.  
I hope my bug report can get this issue fixed regardless.
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJysVU-P27YT_TT0ZSBBov7ZBx-S7M_AD0iBHor2TJEjiVmKVMmRvb7ksxek7Oyu0yY9FFhQa4KceW_e44wIQY8W8ciaj6x52omVJuePX9Bo7PW46526Hj-t3qMlcwWaEEZNoC3h6AVpZ2FwHqQRdswG52dBoBwGy3hHcHH-GZyFP7RV7hJAD_D58--_wEUE0DaQMAYVkAMBi6AJLpOWE0hnSWgbICxCYgDG90Y_I7C2-MSqD4yffvVu9GKGkzYYGD_FoKwtEhR8EfNikLUF44ecFU-s-LCtv006gBQWeoQzej1oVNBfATVNGC-iXEnbMSYaNWVvSaXo3s0gZwXOwxriQQFBx2SweMykm2dNMDn3fCOyRYwMUkB4CBi5bPB4yZqPehYjsuaJ8f1EtISNKuOnUdO09rl0M-OnNaDPBJGQ04yWInsRAqZ_pOo6WdcyK3mnsrorh6zftypTTSF4U3T1YWgYP7ytyf-2akWErxwi2UjjFeC2tsX2F6Y77ipC56deW8ZP37bTGsnDI2vIzg-x3guEICStwkCQXi8ENAmCESnca6lA2-RCtAp0AOOkiLuCfmaPO8pHZfN-U1dY9eq8mGFwxrhLlFk6hf9Ui3g77SxXyCpgvPm62CJ-GX88-zbA_8Eiqs39JlpmXeAS2cbUs1PRnT455-tiI74L-nt1zBWU03Zk_BP0K4EYCD0M2qrk3uYjRadPaJZhNXDBPmj6W2eF0NY3X1mKv6-WxEsm_BjyiWbD-AE0Aa3eBnArwQXBWXNN2NO7VQqCmxH-XF00uvButWorn_aBQPhxjT6Nhwf9AgmZDmHF_FH5NYgRwQ2Jc2SML4uwahPjHucbZRMceJzdOWa1VwirT7ljBTYw8WhwEfJbtDThDL2QzzALm2r5HZBBv6C6OzBqEyD1n4j9X9uA35zAOP-5Gf6rBiBQHBpR9lkxNENW963K9g1vMznUh6psqwM2_KEBZFn23paTOMeKndGn5-B1n54dua119zi4aESrQLmty6cbaN06TkB6xu-1hvka0AyAZ4yvN53UxHgXtQMU4QrOYg7wDYRb4iXo1xE8Ls5Tatwj0tuom1AeR-GVwRDynTpW6lAdxA6PZcebqqj3VbGbjmVZdg0f1L6TvNjXw76UvO8kb5uGD1VV7_SRF7wuDgUvD7yoirxX-6apUBVYl61sa1YXOAttcmPOc-78uEsYjmXRFWW3M6JHE9IU5fxdn-c8zlV_jPeyfh0DqwujA4XXSKTJpAl8Lvd5me9Z8_R-VlQfvpu6Pxyy8cXc5us2WB9G6m715vgDj0Vkt0-2ePcFZewOiXC02Y3z-cj_CgAA___RhZ4O">