<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/101710>101710</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            Inconsistent behavior in lldb-shell :: Unwind/windows-unaligned-x86_64.test
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            new issue
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          kendalharland
      </td>
    </tr>
</table>

<pre>
    ## Overview
My local build of this test produces a binary whose `realign_stack` and `call_func` symbols are not visible to `lldb` so the test fails to match to the expected output of `thread backtrace` as these symbol names appear as empty strings in the stack trace output.

To make this test pass, I had to create [this local patch](https://github.com/llvm/llvm-project/compare/main...kendalharland:llvm-project:kendal/fix-win-unaligned-test) which is certainly not the correct way to fix things but demonstrates my problem well.

## Background

In particular, here are the problems I observe:

1.  lld-link does not produce a binary that exports the `realign_stack` and `call_func` symbols  which are defined as `.globl` in [windows-unaligned-x86_64-asm.s](https://github.com/llvm/llvm-project/blob/90065da6d5a5f661b60c2f75b0f2dc094d27f4f5/lldb/test/Shell/Unwind/Inputs/windows-unaligned-x86_64-asm.s), even though `lldb-pdbutil` indicates that these symbols are “public” in the final executable:

```
PS C:\workspace\llvm-project> C:\workspace\llvm-project\build\bin\llvm-pdbutil.exe pretty --externals C:\workspace\llvm-project\build\tools\lldb\test\Shell\Unwind\Output\windows-unaligned-x86_64.test.pdb | Select-String -Pattern realign_stack

  public [0x0000104e] realign_stack

PS C:\workspace\llvm-project> C:\workspace\llvm-project\build\bin\llvm-pdbutil.exe pretty --externals C:\workspace\llvm-project\build\tools\lldb\test\Shell\Unwind\Output\windows-unaligned-x86_64.test.pdb | Select-String -Pattern call_func

  public [0x00001040] call_func
```

As a workaround I’ve manually exported the symbols in build.py using e.g. `/EXPORT:realign_stack` 

2. LLDB doesn’t appear to load PDB symbols from a separate `.pdb` file automatically. It’s unclear if the original test author ran into this problem from their [PR discussion](https://reviews.llvm.org/D129455) so as a workaround I added an explicit `add-dysm ...` call to load the symbols.

3. LLDB seems to have a hard time parsing PDB files and crashes when `add-dsym` is called. I believe this is a known issue [[1]](https://github.com/ziglang/zig/issues/13095), [[2]](https://github.com/llvm/llvm-project/issues/91060)].  Given that there are 2 PDB readers to choose from: LLDB’s implementation (default) and the Windows Native reader, as a workaround I’ve used the native one by setting `LLDB_USE_NATIVE_PDB_READER=1`.

## Questions

1. Is there any contributor that is currently running this test in their CI, and if so does it pass? (Perhaps @dzhidzhoev).
2. What toolchain differences would cause the `realign_stack` and `call_func` symbols not to exported in one build vs another? Different assembler? Compiler version? Linker version? I would like to fix this locally and then update the test's `REQUIRES` statement if possible.
3. What needs to be done to make LLDB's build in PDB reader function locally? If this test is running in someone's CI without LLDB_USE_NATIVE_PBD_READER=1, there must be some steps I skipped in setting up PDB support and I'd like to document these.
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJzsV1Fz4jgS_jXipQuXLbAJDzwQCFdUze1kk5nbe0vJVoN1yJJLkiHMr79q2RAyM3u5neetSgWw5Fb31193fxLeq71BXLD8nuXrkehCbd3igEYKXQunhZGj0srzgvEJ4xP4fER3VHhi6Zqly3-eQdtKaCg7pSXYHYRaeQjoA7TOyq5CDwJKZYQ7w6m2HoEVqUOh1d68-CCqAytSEEbS80po_bLrTEXP_LkprfYgHIKxAY7Kq1IjBEtbtZZl3GUh1NifuBNKe1pvRKhq-kJL-NpiFVCC7ULbBXKSFWmoHQoJpagOwYkKoxeeXvA4HA1GNOR-26JwtIhNG87gg1Nm70GZaD7GANHGcELSY9P__0LeHPAWF-E94yvYQi0kOVk5FAGB5fdxUw9oSyGwfM34XR1C69lkyfiG8c1ehbork8o2jG-0Pl4-xq2z_8EqML6pbNMKh4xvGqFMkiTv0skmy3f7J8t-mfHNTr2OT8qMOxPzg3JMHjM-h1OtqhqUhwpdEMroc8wJAVBZ57AKcBJnimanXilYQqjsAkhsrPHBiYAemjOxotTYwAm1fgfUwK97UR32znZG3i5uDbTCBVV1WjgCr0aHkRnkwWDTwxZs6dEdkdC6eT1LALSWY63MAaRFH50fCPrGz1CLQHSxLkQm_GWqDjCRXxJ3yqAk2rAiTfbalpq2KkOJPikj7cnfAP16V7wU07HwTeJ_Me2ltiXjm3maFrkUhcxFviuKrCzSiu9meZnuuKzS-VTy2W66y6MBSW_0Sd4816iJBV8Nucf4ZmvaLnjGNx-4y-eUEjwiVYTt9vWlQMetLLughsClqiILIsy3hdbXOHvg7C5l81XblVpVl5_rS6HtlBEa8BWrLohSf59jVqTDX_z5-Awr2pGvTtYdfEslnq_eE__hwy35KjY2-lTmutgHleArUQ9DOMN4jK8BnRHa_wWbwVrt47Is6SelIV_1achXQxry1efYVcjkn6QhoTeTVpbAZit4Ro1VGD_HNgXjRxHIM3hP5BvgAHrAiZfpa5qmaZZOkeXrP3_lb3C_A_etG3wEbErAfr_9PXX7_0sanBSniN0QtpeCmB8RGmE6ofV56FYo-1E0VJMy_TxO2jN0nhzFZJ9QUTK-efj34-enL2yy_KGz3Z7OE_j0aX0fm6W5nhwuwzBY0FZIeFzfX0_dOduAAI-tcHGeFSnBRpZ3SiOILthGBEXBnxPYhqtZD52pNNlVuxiIdWofqz0OzF6TgBMGlIlDXfnrHImnhhqVI5gfn0AqX3XeK2t-1kYdknjxCZEmsW7P-Gad8fk0z2nKeUv9-j3sIKSkPm4Ia60qFSgyIeVYnn0DSZJQhBTUFZWbXLwbcZMBVI80rIKFWhxp_NTCSQiqQRpyMV-EK4Hm47ipnPA1ejjVaK6H-3MT26qPZ6NMYAslaoXHQWwoiuRg7MmA8r6LAoPl9xnB8tGA-ab2Wph9_43xTTRAkyCbpPN8aPi9Pf7_2Pv5wLpanWcpcXPO8nUC8A_VT5J-SgxznkdMSLOhi9hVtSU1Sflnk2UE9oZQqmk1NmiCCMoaYPxO4k50OooZwpRy9Edf8vCbCOqIg3GK7AcS3NZe54dyM_1r1iCUZ_AYAqWOFSn58vL1-eHlt-WX7b8eXh7X9y9PD8v1wxObrDOqi58In9879OSr_064bP0FBXOGyprgVNkF63qAKP2dc2iCPoPrjCEX3rRmPzqVg9U2xmUklZi3vQhSgxidbAigR3S1aD2waSq_1Up-qy0eGZ8n147wR0yJtbqqhTIg1W6HDg1p_JPttIRKdB5_STlFMWnf2pkyPa7xWnGkMrCEArm6Ho4NILzHptT945VtWqXRwRFdrP7JBj4pc3j_ZDt4qtUBb9TqoLr1-cINA10rqYtdLheMz6KSe3r4_ev26eE5Oh9EiCQjUFvr4_0kudZ6hMsgysjXEkFSSGG4EETCktE-RmVuCA4ETyTu4FZ0_fZypfw128qAtw1ag9HcagsnRTIswA88vF_f8pCvBmY1nQ_kH5kBH7AlJe0Pqm37TFyo3bV9w-9aylKEasv47A1Naasu4hHVXTKSi4mcT-ZihItsxnmRFXc8HdULUVXljGc8m02ncyEk8mo62WWpmJSTqsyLkVrwlE_Tu5RnxTTNZklW4CydllzczXlW5DmbptgIpa-NfBSbySJLs1mWjrQoUft4qeXc4KnvgIxTsxq5RexDZbf3bJpq5cPbPBgFFTQutqayxisfKJgSa3FU1hEUUdV6EhFAnW6yhKta_p8CYtQ5vfj1BjmEdVzw_wYAAP___IcsRg">