<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/101406>101406</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            llvm/utils/TableGen/Common/CodeGenDAGPatterns.h: 2 * clumsy parameter passing
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            tablegen,
            code-quality
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          dcb314
      </td>
    </tr>
</table>

<pre>
    Static analyser cppcheck says:

1.

llvm/utils/TableGen/Common/CodeGenDAGPatterns.h:999:63: performance: Function parameter 'InTy' should be passed by const reference. [passedByValue]

Source code is

inline bool TreePatternNode::UpdateNodeType(unsigned ResNo,
 ValueTypeByHwMode InTy,
 TreePattern &TP) {

2.

llvm/utils/TableGen/Common/CodeGenDAGPatterns.h:267:64: performance: Function parameter 'InVT' should be passed by const reference. [passedByValue]

Source code is

  bool MergeInTypeInfo(TypeSetByHwMode &Out, ValueTypeByHwMode InVT) const {

</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJy0k09v2zgQxT_N6ELEkIaSZR10sGM4m0OywcabO0WObbYUqfJPCn37grab-tBLi_YicDjCvDe_B4oQ9NES9dBsoNkWIsWT872SA6_qYnBq7l-jiFoyYYWZA3kmp0meSH5mQcwB-BrKLZTXb7W4rYx5HwF3KWoTAHd7MRh6IAu4u3fj6C4Hla-264cXESN5GxYn4Ouu64Cvlxz4mk3kD86PwkrK5S5ZGbWzbBJejBTJM8D20e5nwJaFk0tGsYHYJEIgxYaZSWdDZJ4O5MlKWjBoNpfuZn4TJhE021vbry55SUw6RUyH2462Rltig3OG7T3R1fOzU9ka8PX_kxKRcr2fJwJcJXvmq9h_FJ4d4P1lEDvr5n828z9fn7LSZYPv_ZvpDHC5fwHsGLSbWzf4h2Djss2w61-A_bb_-7DZhfMT-SNlOBM92oMDXOXjK8UPcoDLf1MEvP8p1Wy1u9r6AFionquOd6KgvmoR62aFvClO_bIrVcMVohCdLEXXqIOsBtmQ6BSpqi10jyXWZcsrLHlbNYumPnBUy5UY2hoFb6AuaRTaLHIgC-ePhQ4hUV-VVV0uCyMGMuH83BBjDumYQ8IcPWLGcPclCaPjnC-bbeH7POhuSMcAdWl0iOHH6Kijof73o2fIANdMmjSG-SbknJi2xyJ5059inM7vHHeAu6OOpzQspMuKV-Gzwcm7TyQj4O68bzZyXfm9x28BAAD__53rZMw">