<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Issue</th>
<td>
<a href=https://github.com/llvm/llvm-project/issues/100064>100064</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>
llvm/lib/CodeGenData/CodeGenData.cpp:177: 2 * clumsy string passing
</td>
</tr>
<tr>
<th>Labels</th>
<td>
llvm:codegen,
code-quality
</td>
</tr>
<tr>
<th>Assignees</th>
<td>
</td>
</tr>
<tr>
<th>Reporter</th>
<td>
dcb314
</td>
</tr>
</table>
<pre>
Static analyser cppcheck says:
trunk/llvm/lib/CodeGenData/CodeGenData.cpp:177:58: performance: Function parameter 'Hint' should be passed by const reference. [passedByValue]
trunk/llvm/lib/CodeGenData/CodeGenData.cpp:177:38: performance: Function parameter 'Whence' should be passed by const reference. [passedByValue]
Source code is
oid warn(Twine Message, std::string Whence, std::string Hint) {
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJykk0Fv3CwQhn_N-IKywsOytg8-eLPy9116StWeMUxsGgwu4ET-95V3t2qqXqrmMmgYBM_M-6JSsqMnakGeQV4KteYpxNboQZTHYghma5-yylYz5ZXbEkWml0VPpF9YUlsC0QG_AL_HHFf_Atg79zrvix0A-8dg6D_yF5XV79lBLwuIrqwqEJ2sQXRsofgc4qy8pj3tV6-zDZ4tKqqZMkUGWP1vfQasWJrC6gwbiC0qJTJs2JgOPmUW6ZkieU0HBvJ8q563L8qtBPLyYVbx96xfpx3j47S3-BTWqInpYIjZ9L4SrGFvKnrA-vOb9cQ-UUpqJMBHlrLZdRJdytH6kf1k-rNym2zDoDrfri1MK0wjGlVQW1ZYVqWUoi6mtm70wKsTH2q-e8VQI45NQ0pxJQdR1YVtkeORVyj4qazl6SC5bKQWtUEtDRkJR06zsu6wC3AIcSxsSiu1Jef8dCycGsilqy8RrxqJbu97JA-IgI-AuOcP31flbN72TXkpYruffRjWMcGRO5ty-vVAttlR-w-CM2SAHdNundPG7sPahbJ-LNbo2inn5foZsAfsR5undTjoML_z1461xPCNdAbsr70mwP7e7muLPwIAAP__L7Uglw">