<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Issue</th>
<td>
<a href=https://github.com/llvm/llvm-project/issues/100065>100065</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>
llvm/tools/llvm-cgdata/llvm-cgdata.cpp:69: 2 * clumsy string parameter passing
</td>
</tr>
<tr>
<th>Labels</th>
<td>
llvm:codegen,
code-quality
</td>
</tr>
<tr>
<th>Assignees</th>
<td>
</td>
</tr>
<tr>
<th>Reporter</th>
<td>
dcb314
</td>
</tr>
</table>
<pre>
Static analyser cppcheck says:
trunk/llvm/tools/llvm-cgdata/llvm-cgdata.cpp:69:39: performance: Function parameter 'Hint' should be passed by const reference. [passedByValue]
trunk/llvm/tools/llvm-cgdata/llvm-cgdata.cpp:68:54: performance: Function parameter 'Whence' should be passed by const reference. [passedByValue]
Source code is
static void exitWithError(Twine Message, std::string Whence = "",
std::string Hint = "") {
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJykU01r3DAQ_TXyZciiHdmxffDBm-3SS08pzVmWZm01WsnVR1r_-2LvQpJCoTRCDDwNzLyZ9yRjNKMj6lh1YNWxkDlNPnRaDWJfFoPXS_eYZDIKpJN2iRRAzbOaSD1DlEtkomf8yPgtppDdM8OTtS8XhqfkvY03eKdGLZN8j3Zqnpno71smerEGmCmcfbhIp2iFp-xUMt7BLIO8UKIADOvPxiWGNcTJZ6thIJhljKRhWEB5FxMEOlMgp2gHrDpcs4flm7SZWHX8GNmGib4q_5ns07Ty-Djda3z0OSgC5TWBiW8z8arTizca6JdJTyZNn0LwgWHz9adxBF8oRjkSwweISa_SiT6mYNwIV5LAxBEY4nYfrmXhr-fPGqsq7yq0wOrDW4qF7oRuRSsL6vY17ut91ZSimLqGmnKoy4GGmpCjPiupsdZlXXMth3ZfmA45lrxGwe-x5GJ31o1S9SCa9kytkJKVnC7S2N0q2M6HsTAxZur2nPP7qrByIBs3lyNugot-3eFI7jYs4orvfmRpTVrWx-pYhG7Tf8hjZCW3Jqb42iCZZKn7H6sDAsMelM2XuMBtfa-mWfU3bixysN2U0rz9MjwxPI0mTXnYKX959e3WYw7-O6nE8LSNvTK5Tf7S4e8AAAD__xesOtI">