<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Issue</th>
<td>
<a href=https://github.com/llvm/llvm-project/issues/97623>97623</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>
llvm/lib/Object/ELF.cpp:415: Poor style ?
</td>
</tr>
<tr>
<th>Labels</th>
<td>
mc,
llvm
</td>
</tr>
<tr>
<th>Assignees</th>
<td>
</td>
</tr>
<tr>
<th>Reporter</th>
<td>
dcb314
</td>
</tr>
</table>
<pre>
Static analyser cppcheck says:
llvm/lib/Object/ELF.cpp:415:54: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
Source code is
const size_t FlagBits = Hdr & ELF::CREL_HDR_ADDEND ? 3 : 2;
I think
const size_t FlagBits = (Hdr & ELF::CREL_HDR_ADDEND) ? 3 : 2;
was probably intended but the code isn't clear.
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJyMks1unDAQx59muIyKYAwLHHzYXRalUtRWyQNE_mJx42Bkm1Tbp6_YjZqc2lwsj6z5f1g_EaM9z8ZwqA9Q95lY0-QD10qyssqk1xf-mESyCsUs3CWagGpZ1GTUM0ZxicD2UPRQvJ3Ovb4ADc5KoOG7_GlUAhpO90OulgXYviprYPu6ArbHmC7ObJejE8GOF1TCqdWJZP2MSzDKaDMrg6MPCNQA7YAaFLO-TmwAanKE-qBu68f3baj7j6Ee_RqUQeW1QRs_vqDyc0wY7W_zlHBw4nywKSKwHu_05rrD0_2wdWT748Pp_umuf3ja9_3pW4_ABmS45Sdgh4-qXzFNdn7-pBFQ-z8voO4fdr9ExCV4KaS7oJ2TmbXRKNeEafrbegZqEipnRMgzzZnuWCcyw8uGioJV3a7NJt6MJNu6NFo1Uo2jane6kqouxrYsVCvqzHIqqCqagpUdddTmTWsqoUtqiUYmZQlVYV6EdfkGQu7DObMxroZ3zY5Y5oQ0Ll5RI3pRQAR0BKIbNbTxF_g2fJHrOUJVOBtTfNdKNjnDP8cY_vA-3Bjb_i5bg-NTSsuVWBqAhrNN0ypz5a9qb6Kb-RL8m-g1fAQabvlfOf0JAAD__6GM8wo">