<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/96132>96132</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            Rename `checkPointerAuthValue` helper
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            new issue
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
            ahmedbougacha
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          asl
      </td>
    </tr>
</table>

<pre>
                  This one is actually interesting: we can't do that as-is, because the helper functions take an `Expr *&`, to do type conversion and placeholder expansion in-place; see e.g., `convertArgumentToType`.
Another existing user makes the modification explicit using a local and `setArg`, but we have a lot of these calls in the checking code here.

We can rename the helper to something explicit though, perhaps `checkAndConvertPointerAuthValue`, and pass the call expr and arg index separately (same for key etc.)

_Originally posted by @ahmedbougacha in https://github.com/llvm/llvm-project/pull/93904#discussion_r1625104653_
 
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJyUk8-O4zYMxp9GvhATyPKfxAcfsrvNtUUxaI8D2qYtdRTJEKXs5O0LKdm2A_SyPtiAKX788SOFzGZzRKPovgilUF9pmXzacNYolBLdtwpT1D6MyLaa_HIf4dPzqg2DdwSGAeeY0No7GBcpEEfjNtGc4TvBjE6oY4TFQ9QYAfnFsFBfYaIZExNETaDJ7hRgTW6OxjuGiO8E6ED08pePPYBQZ6F60cucGX1Ru-8Es3c3Cmy8A3QL7BZn0t4uFIA-dnQlYtxLCYjmCzAR0GE7ZB3Ry0d-PIctXcnFV_9630n08iDkNyHPZ-ejLlqm9ASJKcAV34kL99UvZjUzZuhc0JrZREicjyJYP6MtXKKXTLnKs4MpxeyNxhuVcxH8mgU5-2Utg3FFf9Y0v2ex2S_ZpUBPsMf7z2IvBHJ4_WRk9MD-SlHn3H-4ovZp07n-TkHjzsWBXOLslq8PJ37zZYTnFPUfaBM9gYu5yI-uM2JWDeU3hg2MW-gDmHYMGMneQagTZ6bVB3inO1CcD0IN_4V_-zWYzbiyNrvnSAtMdxCt_LSK2Qkd486iOQt1EeqymajTdJj9VaiLtbcfn5c9-L9ojkJd9mStUJehGWQrVLMYnhPnVXgLda-6WrZ917w9MKBaxmYZmgErGutjfTq1_bE9VnqsFbWyQzxN6zKc1FoPXVu3x6VpJklHPFZmVFK1sldS1qprj4dh6lbsm7Xt6rWhQYpW0hWNPWS-gw9bZZgTjUNfN6qyOJHl5_1z9B1K8Hn3wlh6mtLGopXWcOR_VaKJlsbfH2P_McP_mdxzHaoU7PjTJhYazjYW2tuo_g4AAP__t0Jimg">