<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/95641>95641</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            llvm/include/llvm/TableGen/Record.h:2006: Pointless string copy ?
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            tablegen,
            code-quality
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          dcb314
      </td>
    </tr>
</table>

<pre>
    Static analyser cppcheck says:

llvm/include/llvm/TableGen/Record.h:2006:38: performance: Function parameter 'Filename' should be passed by const reference. [passedByValue]

Source code is

 void saveInputFilename(std::string Filename) {

Suggest use the analyser's advice or use a StringRef.

</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJycUsuOnDoQ_RqzKQ0yZR7TCxbdt8VVdtFMlL2xC3BibOJHS_x9RE8rPdlmg0Qd-VSdh4zRzI6oZ82FNddC5rT40Gs1iqouRq_3_j3JZBRIJ-0eKYDaNrWQ-glR7pGJM-NXxh9fa28rw8E4ZbMmhsNj8E2Olv4nx3B4I-WDLhcmzsh5y8RZvDJxho3C5MMqnaLjd8hOJeMdbDLIlRIFYNgNxpKTKzHsIC4-Ww0jwSZjJA3jDsq7mCDQRIGcohJYc_lAL_t3aTOx5vr53nefgyJQXhOY-BmBmzcaorzRF7fl9Fz8GpM-VItzTMG4GZ7QCVh3-Ys-zzPFBDkSpIX-eMiwiyD1zSgCH-6whPc73RtN5cfjQvdCn8RJFtRXXfVai7bqeLH0U92RmrjWSE0rFCLHSVWndiTCibdUmB451rytGt4hNrykVqrTiEQCdV2JidWcVmlsecRT-jAXJsZM_alp66qwciQb741ATEdy85EcMvyPIR5evfzK0pq0H8PmWoT-4HkZ8xxZza2JKT6Zk0mW-n8qBnz1xiVLMcLDa-W3HZgYihxsv6S03QuIA8NhNmnJY6n8-mS_n7UF_4NUOrYfIiPD4UPnrcffAQAA__85hfRY">