<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Issue</th>
<td>
<a href=https://github.com/llvm/llvm-project/issues/93002>93002</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>
clang/lib/Sema/SemaOpenMP.cpp:7405: Possible & / && mixup ?
</td>
</tr>
<tr>
<th>Labels</th>
<td>
clang,
code-quality
</td>
</tr>
<tr>
<th>Assignees</th>
<td>
</td>
</tr>
<tr>
<th>Reporter</th>
<td>
dcb314
</td>
</tr>
</table>
<pre>
Static analyser cppcheck says:
clang/lib/Sema/SemaOpenMP.cpp:7405:19: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
Source code is
bool IsTemplated = !TemplateParamLists.empty();
if (IsTemplated &
!DVScope.TI->isExtensionActive(
llvm::omp::TraitProperty::implementation_extension_allow_templates))
return;
Maybe better code:
bool IsTemplated = !TemplateParamLists.empty();
if (IsTemplated &&
!DVScope.TI->isExtensionActive(
llvm::omp::TraitProperty::implementation_extension_allow_templates))
return;
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJzMVM9v2yAU_mueL0-xbIid-OBD0tRSpVWLlGrXCvBLwoYNA9zW__1EklbdbjtM2gUw4M_fD30WIejTSNRCtYVql4kpnq1veyV5ucyk7ef2EEXUCsUozBzIo3JOnUn9wCDmAHwDxQ6K26iMGE_AOqMlsO5Ag7hNXx2Nj_tcOQd8s1oWFfBN2QDfYIizobTYWmtIjOgpTCaiDjgF6lGPKHV81YHQOvIiajvmeGeE18cZ6c15CkHbEV91PKMTnsZ4pkAhR6i26nrvzo69Tm9CtfvM92AnrwiV7Ql1-HyCKK01-BCeaHBGROoR-A6Ble8be-HF8EWHGHIaXJyBrYE1wLfvAPqIwNa_IbD6dgis3H07KOsof3pYAL_X4f4t0piUbFTUL5TgrneNeRmSz3xjB3ddPHmh494nQ-J83dKDMzTQGC8OPdM72rMwxr4-xxuJkDiy5gbtKU5-_OB8HR_FLAklxZjStj39EfI_s-Y_dyfrW943vBEZteWqrHld1XyVndumkEeqOD82oi5XNdV9XRSiWddUy-JYrjLdsoIti4qxYl3yapWvRL2sS6pLIUu1LgmWBQ1Cmzypya0_ZTqEidqGFwXLjJBkwqWijN0qxoDdpSfb0-LnJIxOLrNUYd8mkIWcTgGWhbmk8AEbdTTU_lVNcW9D0NJQyggRWHcLCwf9NjkE3mE2edOeY3SXHwLrgHUnHc-TzJUd0odSSNdp4bz9TioC6y4aA7DuIvNXAAAA__-noWyu">