<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Issue</th>
<td>
<a href=https://github.com/llvm/llvm-project/issues/91188>91188</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>
libclc/generic/lib/math/log_base.h:212: Possible &&/& mixup ?
</td>
</tr>
<tr>
<th>Labels</th>
<td>
code-quality,
libclc
</td>
</tr>
<tr>
<th>Assignees</th>
<td>
</td>
</tr>
<tr>
<th>Reporter</th>
<td>
dcb314
</td>
</tr>
</table>
<pre>
Static analyser cppcheck says:
libclc/generic/lib/math/log_base.h:212:36: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
Source code is
int is_near = x >= log_thresh1 & x <= log_thresh2;
Perhaps better code:
bool is_near = x >= log_thresh1 && x <= log_thresh2;
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJycUk1vnDAQ_TXDZRQENrDhwGE_yjlSfkBkm8kyrRdTj0my_77yNlHTXlr1As969pt5T8-I8HkhGqA9QHsqzJbmEIfJWV03hQ3TdXhMJrFDsxh_FYro1tXN5L6hmKuA3kN1gur969k670CNZ1oockaeLajxYtKcD-H8ZI1QOYPeq1qB3usO9B4lXT1lcAjBk1kwkmw-IQtuQhPygpbTKwthWCmaxGEp8ehN5Ocr0tsaSYTDgq-cZlxNpCXNJCQlQntwP-8dwzJxfgnt6fPWj2GLjtCFiZDlM4OIvOQtnhYyEUGf8A1Bf8kge0lzJJlrBNXdiOPvhAJ9-Cz3QHE2q6CllHKSYaI_AkQbgv-neX8dWUyDnnrdm4KGelc3fd-0uinmQbct1bvWUtX198YQTeZZaUut61X9rHYFD6pSTdVWXV0rVeuSqs5WbUc72xnrSENT0cWwL71_uZQhngsW2Wjo6_r-vvDGkpdbo5TKHu--b8ZzuoJSoI6g1EdNVK5cHLLKnd3OAk3lWZL80k2cPA3_USt8CCJsPb1nBWrMiV34bVsR9Fhs0Q9zSuutwpkcz5zmzZYuXLKkf_n43a0xfCWXQI03mwJqvDn9EQAA__9gogGJ">