<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/90284>90284</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            clang/lib/Driver/ToolChains/HIPUtility.cpp: 2 * poor choice of range variable type ?
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            clang:driver,
            code-quality
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          dcb314
      </td>
    </tr>
</table>

<pre>
    Static analyser cppcheck says:

1.

clang/lib/Driver/ToolChains/HIPUtility.cpp:63:17: performance: Range variable 'Name' should be declared as const reference. [iterateByValue]

Source code is

      for (auto Name : FatBinSymbols)

2.

clang/lib/Driver/ToolChains/HIPUtility.cpp:65:17: performance: Range variable 'Name' should be declared as const reference. [iterateByValue]

Source code is

      for (auto Name : GPUBinHandleSymbols)

Duplicate.


</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJzUk0GP2ywQhn8NvozWwgOOk4MPyUb-9rtUq2639zFMYlpiXMCR_O8rp1s1K_VU9VIOoBnEvMPzAqXkziNzK-qDqI8FzXkIsbWmV5Uu-mCX9iVTdgZoJL8kjmCmyQxsvkKiJQm1F_Io5NtclfeR8TSeBXbe9QK7Y3RXjgK7TyH4x4HcmAR2T_8_v2bnXV5KM01C7TdKqH3VCLWHieMpxAuNhtfwI41nhitFR71nENh8oAsLbCANYfYWegbLxlNkC5TAhDFliHziyKPhEkR9cJkjZT4sn8nPLOrjfb8vYY6GwQTL4NL9DtzGKUQQuKU5B1ilYe2qo3xw48ty6YNPAnf3x_Av4Kj_LRz_Pb8e3PhEo_X8eyjHefLOUOZ3cArbKrtTOyq4rZpKV43Um7oY2loS27ppGtSVbnY1bSqDUp40bfsGKypcixK11LhBxEbXpZTabIwyWpFVZrcVWvKFnC-9v17KEM-FS2nmdidxqwtPPft0e_-IPyxSe_tmDgp8XNPB8sO3mVZf1mR9LGK7Vnvo53MSWnqXcvpVP7vsuf0jvwFB4B6mECKYITjDEE4Q33udl2ml3RVz9O2Q83T7h9gJ7M4uD3NfmnBZlf315_IwxfCFTRbY3W6_it8AfA8AAP__CBs9Rw">