<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/89940>89940</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            Generic Operation builder does not set up properties
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            new issue
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          jschj
      </td>
    </tr>
</table>

<pre>
    We use some of the auto-generated “generic” builders with return type inference for some our operations in our code base. They roughly look like this:

```
void MyOp::build(::mlir::OpBuilder &odsBuilder, ::mlir::OperationState &odsState, ::mlir::ValueRange operands, ::llvm::ArrayRef<::mlir::NamedAttribute> attributes) {
  assert(operands.size() >= 1u && "mismatched number of parameters");
  odsState.addOperands(operands);
  odsState.addAttributes(attributes);

  ::llvm::SmallVector<::mlir::Type, 2> inferredReturnTypes;
  if (::mlir::succeeded(MyOp::inferReturnTypes(odsBuilder.getContext(),
          odsState.location, operands,
          odsState.attributes.getDictionary(odsState.getContext()),
          odsState.getRawProperties(),
          odsState.regions, inferredReturnTypes))) {
    assert(inferredReturnTypes.size() == 1u && "mismatched number of return types");
    odsState.addTypes(inferredReturnTypes);
  } else {
    ::llvm::report_fatal_error("Failed to infer result type(s).");
  }
}
```

The problem is that at no point the properties are set up. The other builders (the ones where the individual operands are provided) do eventually call `odsState.getOrAddProperties<Properties>();`. This poses a problem in our case since we rely on operandSegmentSizes (which is a property) to be correctly set up. This issue is happening with the release version of LLVM18.

To reproduce someone might simply look at the generated "generic" builders of any operation with properties.

[Discourse link](https://discourse.llvm.org/t/generic-operation-builder-does-not-set-up-properties/78552)
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJyMVk9zo7gT_TTypcsuEMbAwYckjn-XmV-2kqnZ45RAbdCMkChJJMt8-i0JMHiS2d1UypFI_3n9-tFtZq2oFeKRpPckPW1Y7xptjt9t1XzflJoPxz8ReotgdYugL-AaBNY7va1RoWEOOZBHSvKIFA_hkajm-wnKXkiOxsKbcA0YdL1R4IYOQagLGlQVwkWbKXhvQHc-ptDKglDhSaU5Qsks7uBLgwMY3deNHEBq_QOk-IHgGmFJckeiE4nmz0M0_YbrqxYcPg9PnTdL7gIqQvPx1kphxtNTdz_iBUIPmtvpRugDvDedcL445nCyD-ePrL8y2eMzUzWOBSpuFzMpX9vxdGcMG57xQpKHXyP8n7XI75wzouwdkuQR2HyxhBZAsvuxVABmLRpHaD6n2lnxE3253i55JMkJ4t5DJvQAhNJW2Ja5qkEOqm9LNL7NHTOsRYfGEkoJLUhyTTBXumOcP13LyZfKfmd8t4Kc3-C_Osxuv1Lz0jIpv2LltPmAnS9DF3innpigLIP8OajN_8uu8IgLfNB521cVIkevikUnIdI6DM0XVexqdA9aOfzLjdwS-jAnmX-uxUtdBbV4kCsF_NZ-IcenOYnKOzMzjAhGm_f5_xFCje6Zvf1hfHonQjH_4mGw9i-ix_wRp1PGG-2t1PeBy60QT_9NiKuh8V6Kt_qam_QbtIsbyU6A0uIt9F81Z7DTxn27MMfkNzRGm4CdnpmQyMHpkRYwaHvpAkJCc59q9w4oyU6TwK-H2xE1fn5pEDqjS4ktCAuuYQ6YA6Wh00K5MHy7awuBGQSLDvouDEfQrkGzDF1Cc--gFVp4a9Bg8BeKi1fBeyavUgyBOqNfRXgFCuAa8BWV65mUA1RMSiCHaK2lJ3PH-UpNycP68jipK7knh8hjExY6bT3kpb5pvjO_XITfBG8IBuUAWs3IXrBuUbkX8RNDOW-NqBrPDJtpGDxcp6FEqLQxWDk5rDgRFoS1PXqfhnUdKqHqcRt5LgxK9Plf0Vjh017g06evn-N8d9MVDQY7o3lfjXtQK4RW1I0DK9puXkZs7M9qL1I6b0RKl7boCzA1LKtuhLO09SY3Se9Pwla6NxZBCvWDpCdC88a5Liw9eib0zGeLnVfvTpua0LMj9Dyl315zbScUW67RbpV2W4tu23fbbjUYzlmepl7AG35MeJEUbIPHOIuTIqPxodg0xzzb8yThe3aIkzSOD5c45Vl6KJBdorLM0o040ojuoz3dxyml-2K3j7PkkEUXzqp9Fu9jso-wZUJeEW9Cn455UeyjjWQlShu-k1Cq8G1son-r0tPGHL3PtuxrS_aRFNbZJYoTTuLxf2PdcF3TM_vg6wal3aSRFe2b3sjjLa-1cE1f7irdEnoOg2H849n6jpVnOADznAXgfwcAAP__qCH8Cg">