<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/89805>89805</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            clang/lib/Lex/Pragma.cpp:1447:14: style: Suspicious condition
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            clang
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          dcb314
      </td>
    </tr>
</table>

<pre>
    Static analyser cppcheck says:

clang/lib/Lex/Pragma.cpp:1447:14: style: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]

Source code is

         if ((SpecifierValid = SpecifierInt != -1))

I suspect the following code was intended:

         if (SpecifierValid = (SpecifierInt != -1))

</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJyskkFvnDwQhn-NuVhBMAatOXDIZoUU6Tt80kq9D2YAtwZbHpNk_30FSdpV1N7qg8caj995xnqR2U4rUSvqs6gvGW5p9rEdTK_KKuv9cGuvCZM1Eld0N6YoTQhmJvNDMt5YqEdRXETxsRuH6ySgc7YX0P1HbwK6_yNOC-YmBKEey6o6HUGoR8np5mg_XDcO1li_sTR-HWyyfpUC9DvdQmuSAs7S-CVgtOxXAY1QZ_nkMNrxJuktRGLeX73aNMuAkdY0ExPnUtRn81739Kkt6ss99dVv0ZA0fiBp-f5Gfi477jwC9DWQsaOl-A2dHaRQF_kr9XxwlnvuodwRobkXe5a8cSCTZJpJjt45_2rX6b3vK7K0a6J1oOHLp36B-APBffavENnQqqFRDWbUlqdS6UbX6pTNrYaiVwBljcWpqRWWper1gIiFGrXph8y2UEBVVKBKXdfqlFcw6r4AhSXqShOIqqAFrcude1lyH6fMMm_U6kYXdeawJ8eHwwA-HAK72WK71z_028SiKpzlxL8Vkk2O2n9oqGyLrp1TCodpoRPQTTbNW58bv-wt3MtneAjRfyeTBHTHICygO2b5GQAA__8_1fpz">