<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Issue</th>
<td>
<a href=https://github.com/llvm/llvm-project/issues/89193>89193</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>
llvm/include/llvm/CodeGen/MachineScheduler.h:810: pointless copy of a list ?
</td>
</tr>
<tr>
<th>Labels</th>
<td>
llvm:codegen,
code-quality
</td>
</tr>
<tr>
<th>Assignees</th>
<td>
</td>
</tr>
<tr>
<th>Reporter</th>
<td>
dcb314
</td>
</tr>
</table>
<pre>
Static analyser cppcheck says:
llvm/include/llvm/CodeGen/MachineScheduler.h:810:51: performance: Function parameter 'Intervals' should be passed by const reference. [passedByValue]
Source code is
explicit ResourceSegments(std::list<IntervalTy> Intervals)
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJykkjtv2zAQxz_NaTnE4EOKrUGDE1dFhy510Z0izxZbilT5CKpvX1BJkexdCNwDd7___alSsndPNED3BN2lUSXPIQ5GT5K3zRTMNlyzylaj8sptiSLqddUz6V-Y1JZAnoFdgL29zr0sIEbrtSuGQIxviedg6DN5EONXpWfr6apnMsVRPMwgzyfOQJ47DvKMK8VbiIvymmo4Fq-zDR5XFdVCmSKCOH7xmeKLcgnEEdMcijM4Ea4qJTI4baiDTxkj3SiS13RA6J5eq0_bD-UKQXf5CH4NJWpCHQyhTR8riPRndVbbjN8o7W1Xui_kcwJxStnUE8izsymDfP4H9n0D-Qk_YPav0xozSNPLXjU08COXrZQdf2zmQd66SbFu4tJMhtjJTD2TfdcqejTiRrKxg2CiZS0_sb7t-ONBC9PfBGeGc8bVsYeW0aKsO9SbH0K8NzalQsOp571snJrIpd1mIXZX5LmqvVdXBIhnEKLGD7-LcjZvNdldmjjU3oep3BO0rIpM7_OzzY6G__Ic12B9dpQS6rBuGG6osK5BkGNTohvmnNf9m4kRxHi3eS7TQYflfdFOuMbwk3SuIFV1AjHuwv8GAAD__-cs7Dw">