<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/89194>89194</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            llvm/include/llvm/LTO/legacy/LTOCodeGenerator.h:100: pointless copy of a vector ?
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            code-quality,
            llvm
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          dcb314
      </td>
    </tr>
</table>

<pre>
    Static analyser cppcheck says:

llvm/include/llvm/LTO/legacy/LTOCodeGenerator.h:100:42: performance: Function parameter 'MAttrs' should be passed by const reference. [passedByValue]

Source code is

  void setAttrs(std::vector<std::string> MAttrs) { Config.MAttrs = MAttrs; }

</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJykUs2OnDwQfJrm0lpk2rAMBw7z8_FdEuWwUe7GbsCJBxPbjMTbR8zMZveei6WqktxV3aVitOPM3EJ1guqSqTVNPrRG97Ios96brX1LKlmNalZuixxQL4ueWP_CqLYI8gjiAuL5One7AnV21m41DNQ9iS_fv-2AR6W3Bzx7w__zzEElH_IJ5LEQAuSxJJBHXDgMPlzVrHmH3TrrZP2MiwrqyokDAtVfjymFCFRjnPzqDPaMi4qRDfYbaj_HhIEHDjxrzhGq00M9bT-UWxmqy2frb34NmlF7w2jjZwXx5q3ByOk58BCT2YPL44118gHk-S8TU7DzCPI_fLfXINQnPPt5sGP-IBHk5V2XJ4T66SQzrTSNbFTGbVEXspTyQE02tfwqK6WrWmihxSurZjioqhxY1ySKajCZbUlQKcriIJpKUJO_EqvhQMJUphlYE5SCr8q6fL9I7sOY2RhXbg9N0ZSZUz27eC8B0b6Cl9-rcjZtQAR0BqLHIWnvSGh38NKvY4RSOBtT_Pg12eS4_fce4OLtnBzHiNovG_oBFT7WjSC7bA2unVJa7g2kDqgbbZrWPtf--jHvbnQJ_ifrtPvZI0eg7p76TwAAAP__KB3xJw">