<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/88617>88617</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            [clang-tidy] Add check for variable that can be moved but isn't
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            clang-tidy
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          sweemer
      </td>
    </tr>
</table>

<pre>
    I would like to request a clang-tidy check for variables that can be moved but are not. For example, in the following code `string` can be moved into `f1` to save an unnecessary copy but there is apparently no check for it at the moment. Can it be added?

```c++
#include <string>
#include <utility>
#include <vector>

void f1(std::string string) {
 std::vector<std::string> vector;
 vector.push_back(std::move(string));
}

void f2() {
  auto string = std::string();
  f1(string);
}
```

```console
$ clang-tidy --version
Ubuntu LLVM version 19.0.0
  Optimized build.

$ clang-tidy -checks=*,-llvmlibc-* move.cpp
Error while trying to load a compilation database:
Could not auto-detect compilation database for file "move.cpp"
No compilation database found in /home/sweemer/test or any parent directory
fixed-compilation-database: Error while opening fixed database: No such file or directory
json-compilation-database: Error while opening JSON database: No such file or directory
Running without flags.
39836 warnings generated.
Suppressed 39836 warnings (39836 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
```
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJyUVU2P4ygT_jXkUrJlQz4POWSSjvS-mu2RdjR7XWGoxExj8EI5meyvX4GT6XSm-zASSmSK56OgCmSM5ugQ12z2ic12EzlQ68M6nhE7DJPG68v6f3D2g9VgzQsCeQj4z4CRQIKy0h0LMvoCqkX1Agcf4CSDkY3FCNRKAiUdNAidP6GGZiCQAcF5KmHvA-AP2fUWGd-CcUAtwsFb68_GHUF5jcDmVaRg3JHNq7dcxpFP4UOdQuQhyhOCdDA4hwpjlOECyveXrEotBgQTQfa9DOjIXsD5O9uGQOZl0PkOHZWwlS7NNghSa9RM7Fm1Y9Xm-juvxqEY_5TGOMuFccoOybnYXp2Lp_eCAxlr6PJB9ISKfHgN5t-TNxoONePLSJqJDRObUQKuSnwFbHG1Aj_X3Li2DygmnuAWu4HG77IfYvt3I9XLvVba9_x91UrjBmSL3a9OOePLt55ADumkRtNM7ODRUga82rlle1P8Ve52DO-fjXfRW7xt8PS-YovihCEa78bot2ZwNMDnz3_9AdcA1KuyKqublS89mc78m8vYWF2-UXzgznUVmdgxvmF8W1h76qxpVMH4Jtdvqfp-hD6F4AOcW2MRKFzSxpAH66VOHea73lhJyY2WJBsZMe1XRm5zWzpPeVcLjYSK3oXkCj8kBcb5T3nOR55n_xFocKnPgPF96ztkfH-9GBjfU7oCfADpLjB2FGgTcvVcRtqD-YG6uGMu7jKA-7R9jy7lnRH3ecKzhziodvTuw6PE9-jdbyn8_-uX598R-HNwGXc21PqB4GDlMV5PXqyWYg5nGdKKCEd0GCThrTC-Dn0fMEbU8LCS8eU4Yxw474ohYsi3HeOrK_hbRChalBpDcTCWMDCxK1PxkAdtYm_lBTAlGOEQfAfS2swVL5GwgxEaS8hE4-SVL35E8RYKMsIZrS0fWmqi10KvxEpOcF0valFVq_lqOWnXjVyKZtYspRaHxXzVKCXFrJKLmtfzuZZyYta84tNqWouaV7VYlqKezdVU6amarZbiMGXTCjtpbJm6pfThODExDrheLuf1YmJlgzbmh4rz115LVTzbTcI6gYpmOEY2rayJFF9pyJDNT9wdbLaDjdbvvFsfPFsmOsYXNBmCXbdEfUxtyPeM74-G2qEple8Y3yfN61_RB_8dFTG-z3lExvc5lf8CAAD__7O8ZO8">