<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/88506>88506</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            [mlir] inferReturnTypes doesn't work with properties in ODS-generated parser
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            mlir
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          JoelWee
      </td>
    </tr>
</table>

<pre>
    When we have ODS-generated assembly format and want to infer the return type, it doesn't work.

E.g. I extended TestOpWithProperties to have a return type, and to infer that return type

```
def TestOpWithProperties : TEST_Op<"with_properties", [DeclareOpInterfaceMethods<InferTypeOpInterface>]> {
  let assemblyFormat = "prop-dict attr-dict";
  let arguments = (ins
 IntProperty<"int64_t">:$a,
    StrAttr:$b, // Attributes can directly be used here.
    ArrayProperty<"int64_t", 4>:$array // example of an array
  );

  let results = (outs
 Variadic<AnyType>:$results
  );
}

...

LogicalResult TestOpWithProperties::inferReturnTypes(
    MLIRContext *, std::optional<Location> location, ValueRange operands,
    DictionaryAttr attributes, OpaqueProperties properties, RegionRange regions,
 SmallVectorImpl<Type> &inferredReturnTypes) {
 TestOpWithProperties::Adaptor adaptor(operands, attributes, properties,
 regions);
  // Fails when trying to access the "b" operand.
  if (!adaptor.getB().empty()) return failure();
  return success();
}

```

Code is here as well: https://github.com/llvm/llvm-project/compare/main...JoelWee:llvm-project:piper_export_cl_624139506

When running the mlir-opt test `/llvm-project/mlir/test/IR/properties.mlir`,

we get a crash with

```
Stack dump:
0.      Program arguments: mlir-opt /build/work/c7ba005c238e0434776d2e70e8f76290545d/google3/runfiles/google3/third_party/llvm/llvm-project/mlir/test/IR/properties.mlir -split-input-file
1.      MLIR Parser: custom op parser 'test.with_properties'
```

===

Doing some digging, I think the following is happening:

1. The assembly format doesn't have return type, so we infer it during parsing
2. The `parseProperties` function parses the properties into operationState.propertiesAttr, but this only gets converted to a proper Properties class after parsing.
3. During parsing, we apply inferReturnTypes to get the return type, but the info is neither in properties nor attributes, it's in propertiesAttr which isn't passed in at all.
4. So parsing fails because we try to access something in properties which isn't there (yet)

The auto generated parser looks something like

```
::mlir::ParseResult TestOpWithProperties::parse(::mlir::OpAsmParser &parser, ::mlir::OperationState &result) {
  if (parseProperties(parser, result))
    return ::mlir::failure();
  {
    auto loc = parser.getCurrentLocation();(void)loc;
    if (parser.parseOptionalAttrDict(result.attributes))
      return ::mlir::failure();
    if (failed(verifyInherentAttrs(result.name, result.attributes, [&]() {
        return parser.emitError(loc) << "'" << result.name.getStringRef() << "' op ";
      })))
      return ::mlir::failure();
  }

  ::llvm::SmallVector<::mlir::Type> inferredReturnTypes;
  if (::mlir::failed(TestOpWithProperties::inferReturnTypes(parser.getContext(),
 result.location, result.operands,
 result.attributes.getDictionary(parser.getContext()),
 result.getRawProperties(),
      result.regions, inferredReturnTypes)))
    return ::mlir::failure();
 result.addTypes(inferredReturnTypes);
  return ::mlir::success();
}
```


(Note for myself: to test this, I copied over the autogenerated parsers and printers and added CHECKs here and there)

</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJykWN9v4jAS_mvMy6gROIQfDzywUHS9272u2mr3sTLJkPjq2DnbKct_fxongQTaXa2uqiA49nwzn8czXyKck7lGXLHkC0u2I1H7wtjVPw2qn4ijvclOq58FajgiFOId4XH7fJejRis8ZiCcw3KvTnAwthQehM7gKLQHb0DqA1rwBYJFX1sN_lQh4xuQHjKDTjM-93A09i1i4y0br5vP-yiP4AHwl0edYQYv6Pxj9VP64rs1FVov0ZH54I24tk0O9LCFH0zowbDZuP0PPzM8fIzE4jW83D-_vD5WLN4wzo_SF6_VeQLjnHBZ8mWLqRIWH6sH7dEeRIrf0BcmcyzePJA_L6eqf5fF9yzZsvge2PxL4wWAQn8mdddwyuItMM4J8i6TqQfhvQ1XhB0Pl9q8LlF7165aSO3a-w_at2GdmkCk9rPpa2PknsVrxqeC8U1nDuDZ27X3trm1D1HyHeM7oFG5rz06SIWGTFpMvTrBHqF2mEGBFqOLnbW14vQpNt_A9OIATe1g8JcoK4VgDiA0hFudUcaX58j78Vt0tbpEb2rfhf9DWCkymbJ4s9Yn2oozaLvoQ9vzbR8kigap-tXkMhXqKaz_MH0IIF6HbHwKeUjAjvHFhZ1vXx-eNkZ7_OWB8TXx4XzWLDSVl0YLxeLNV5MK-kH5orprvoEfQtX4JHSOQKBCZ26wiVuZBhv2RLsWcqfZOlr8WIn_1tjL9n5eb-AJc2l0Y9yG657t51Io9QNTb-xDWZGLLanA-CxEbDEbBL3sJfrnZK0zUXljQTTftIuXuK78H7jbWj47uuydjTajdkIqB0eqZ96epM6pVog0RedCoWKc7xnnHZPnHJYHyibGJ61TUY7-SxhZRlhW_tRcU4htuTkIqWqL7fjFkfa2qwPo1e2rbLsqUc3nxmQI0oUzBsLBEZWiGlV4XwUGQ6S59EW9j1JTMr5T6r37uqus-Q9S5dilpqwEebgrhdRRFLU1n8Xrwcx4XckK7Sv-qoz1r6l6nfHpJF4m41nfr9AkbK11YLVAKJW0d6by4NF5oChuXKApjO9oAuO7hyfGd5cdjcJdWrbp4xwRcip0kFrhCqBq_BvOnr1I3yCry4qoCUPjCMLfd2tyK8pLySQWz04zvtvXUmWM76hDEV_zvRiPk5THCxxP4-l8Pss4zse4OMxnfDlOpgnNzo3JFcaM72ytD1JRavYGfSFt9loJqoSf7cyfaYE7Vynp76Suan9HKE1skzY2qinwXViHVL0hrZ03JZgKqjAG1HnR-eiml81_k3ks3rb_vcGtof12pkTIZJ5LndO5fABfSP0W8uBglDJHmkVZK6oKKUXO23F2_KXAGzlxkQmh21_1emdIlTStnjRFbQmFQiSAYJc3dtlsHCLv1ZrZGA61DrWxYaWpABcyQGpvmkpAk5698BhdbofOyDewrz0F68BodaLUdJAa_Y6W5BFVl9Yk9KpsqoRzIA4ebeduW2riCLbDMPiGghRVpU5w3UfIPh2GDzRW41ZgxxDxGqUviCfdD1Gb644gPeNzN5wWGsexkGkBst2OinYqo2kk-pRq3Z9G8Gw610MNdLDHVNQOKQpvT72CS0lDaZJfOTVE8qHQMb44oada2UuakDF14KDTo21-K2Pe-gBKvv1O_DWNJxy7cBVOzh-7esCiCn61-rFau_J7d9BmjUtBPd1M7OcWzW2UyLBTts3nOn_bkWD4vOxMEBWBNiOuUT_rTD1EaGhVJg1CqgGinreprUXtz1rkbIMv3o3MGF8qk_ZsDpy3Ufh6bDUNZdU2iNhF43_Uz8RhKH8dTAdM9zEj99DKw-lBUzZpT9juAqxFiRceo-GJoAcjPiOlHkCGPPVca2PEUvp7a4NwITJoRbxhMYlnTgWW826gh07kPns6-E946ID6y6h4D-U-_ZFgaKj6v9i60h3QLgzdKVz1tF7wami2030fib74Ko0_cils0F-p515GNsq5018XERio7QvlduhWJN_sOtm9yObfwd0i5uifxHFwTgfT2u0Jcy-S-kPqbjf277a1iyvLOto-QblRp9cAf1KrH6qF5pMv_m08iQAL5cmhOpAe8aYRhdQ3G7mQmkpiBua9fWNA9ee6qrvwcF9ZSQ_QzQ-RZZjB5h_3m391ipie_-nqTNwoW8XZMl6KEa4m8wlf8uk8mYyKVTLh0_lsNjmMUzFbLOZ8P9lPJrg_cJ7wRTwZyRUf8-l4OuETzpNkEk0wmS0myyQ5ZMtJNluy6RhLIVVEJyUyNh9J52pcLRbJeDZSYo_KhRcrnDeajrNkO7KroPf2de7YdKyk8-5iwEuvwsuYsCDZ3vb84auTIICHquXqFU1D3qi2avXXzwghHBKwIaL_BQAA___DFrhx">