<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Issue</th>
<td>
<a href=https://github.com/llvm/llvm-project/issues/84807>84807</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>
[ArgPromotion] Miscompile at -O3
</td>
</tr>
<tr>
<th>Labels</th>
<td>
miscompilation,
llvm:optimizations
</td>
</tr>
<tr>
<th>Assignees</th>
<td>
</td>
</tr>
<tr>
<th>Reporter</th>
<td>
dtcxzyw
</td>
</tr>
</table>
<pre>
Reduced test case: https://godbolt.org/z/5z5sYv4nq
```
#include <stdint.h>
#include <stdio.h>
struct a {
int16_t b;
uint64_t c;
} f = {1};
uint8_t d, h;
static struct a *g[] = {&f, &f, &f, &f};
int32_t i;
static struct a j(struct a *q) {
for (d = 5; d < 6; d = d + 1)
f.b = h;
return *q;
}
int main() {
struct a *l = g[3];
*l = j(l);
i = f.b;
printf("%d\n", i);
}
```
Bisected to `ArgPromotion`.
Before:
```
; ModuleID = 'test.c'
source_filename = "test.c"
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-i128:128-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
%struct.a = type { i16, i64 }
@f = dso_local global %struct.a { i16 1, i64 0 }, align 8
@i = dso_local local_unnamed_addr global i32 0, align 4
@.str = private unnamed_addr constant [4 x i8] c"%d\0A\00", align 1
@d = dso_local local_unnamed_addr global i8 0, align 1
@h = dso_local local_unnamed_addr global i8 0, align 1
; Function Attrs: nounwind uwtable
define dso_local i32 @main() local_unnamed_addr #0 {
entry:
%tmp.sroa.4 = alloca [6 x i8], align 2
call void @llvm.lifetime.start.p0(i64 6, ptr nonnull %tmp.sroa.4)
%call = call fastcc { i16, i64 } @j(ptr noundef nonnull @f)
%0 = extractvalue { i16, i64 } %call, 0
%1 = extractvalue { i16, i64 } %call, 1
store i16 %0, ptr @f, align 8, !tbaa !5
call void @llvm.memcpy.p0.p0.i64(ptr noundef nonnull align 2 dereferenceable(6) getelementptr inbounds (i8, ptr @f, i64 2), ptr noundef nonnull align 2 dereferenceable(6) %tmp.sroa.4, i64 6, i1 false), !tbaa.struct !9
store i64 %1, ptr getelementptr inbounds (%struct.a, ptr @f, i64 0, i32 1), align 8, !tbaa !10
call void @llvm.lifetime.end.p0(i64 6, ptr nonnull %tmp.sroa.4)
%conv = sext i16 %0 to i32
store i32 %conv, ptr @i, align 4, !tbaa !12
%call1 = call i32 (ptr, ...) @printf(ptr noundef nonnull dereferenceable(1) @.str, i32 noundef %conv)
ret i32 0
}
; Function Attrs: mustprogress nocallback nofree nosync nounwind willreturn memory(argmem: readwrite)
declare void @llvm.lifetime.start.p0(i64 immarg, ptr nocapture) #1
; Function Attrs: nounwind uwtable
define internal fastcc { i16, i64 } @j(ptr nocapture noundef readonly %q) unnamed_addr #0 {
entry:
br label %for.cond
for.cond: ; preds = %for.body, %entry
%storemerge = phi i8 [ 5, %entry ], [ %add, %for.body ]
store i8 %storemerge, ptr @d, align 1, !tbaa !14
%cmp = icmp ult i8 %storemerge, 6
br i1 %cmp, label %for.body, label %for.end
for.body: ; preds = %for.cond
%0 = load i8, ptr @h, align 1, !tbaa !14
%conv2 = zext i8 %0 to i16
store i16 %conv2, ptr @f, align 8, !tbaa !15
%1 = load i8, ptr @d, align 1, !tbaa !14
%add = add i8 %1, 1
br label %for.cond, !llvm.loop !17
for.end: ; preds = %for.cond
%retval.sroa.0.0.copyload = load i16, ptr %q, align 8, !tbaa !5
%retval.sroa.25.0.q.addr.0..sroa_idx = getelementptr inbounds i8, ptr %q, i64 8
%retval.sroa.25.0.copyload = load i64, ptr %retval.sroa.25.0.q.addr.0..sroa_idx, align 8, !tbaa !10
%.fca.0.insert = insertvalue { i16, i64 } poison, i16 %retval.sroa.0.0.copyload, 0
%.fca.1.insert = insertvalue { i16, i64 } %.fca.0.insert, i64 %retval.sroa.25.0.copyload, 1
ret { i16, i64 } %.fca.1.insert
}
; Function Attrs: mustprogress nocallback nofree nounwind willreturn memory(argmem: readwrite)
declare void @llvm.memcpy.p0.p0.i64(ptr noalias nocapture writeonly, ptr noalias nocapture readonly, i64, i1 immarg) #2
; Function Attrs: mustprogress nocallback nofree nosync nounwind willreturn memory(argmem: readwrite)
declare void @llvm.lifetime.end.p0(i64 immarg, ptr nocapture) #1
; Function Attrs: nofree nounwind
declare noundef i32 @printf(ptr nocapture noundef readonly, ...) local_unnamed_addr #3
attributes #0 = { nounwind uwtable "min-legal-vector-width"="0" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cmov,+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "tune-cpu"="generic" }
attributes #1 = { mustprogress nocallback nofree nosync nounwind willreturn memory(argmem: readwrite) }
attributes #2 = { mustprogress nocallback nofree nounwind willreturn memory(argmem: readwrite) }
attributes #3 = { nofree nounwind "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cmov,+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "tune-cpu"="generic" }
!llvm.module.flags = !{!0, !1, !2, !3}
!llvm.ident = !{!4}
!0 = !{i32 1, !"wchar_size", i32 4}
!1 = !{i32 8, !"PIC Level", i32 2}
!2 = !{i32 7, !"PIE Level", i32 2}
!3 = !{i32 7, !"uwtable", i32 2}
!4 = !{!"clang version 19.0.0git"}
!5 = !{!6, !6, i64 0}
!6 = !{!"short", !7, i64 0}
!7 = !{!"omnipotent char", !8, i64 0}
!8 = !{!"Simple C/C++ TBAA"}
!9 = !{i64 6, i64 8, !10}
!10 = !{!11, !11, i64 0}
!11 = !{!"long", !7, i64 0}
!12 = !{!13, !13, i64 0}
!13 = !{!"int", !7, i64 0}
!14 = !{!7, !7, i64 0}
!15 = !{!16, !6, i64 0}
!16 = !{!"a", !6, i64 0, !11, i64 8}
!17 = distinct !{!17, !18}
!18 = !{!"llvm.loop.mustprogress"}
```
After:
```
; ModuleID = 'test.c'
source_filename = "test.c"
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-i128:128-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
%struct.a = type { i16, i64 }
@f = dso_local global %struct.a { i16 1, i64 0 }, align 8
@i = dso_local local_unnamed_addr global i32 0, align 4
@.str = private unnamed_addr constant [4 x i8] c"%d\0A\00", align 1
@d = dso_local local_unnamed_addr global i8 0, align 1
@h = dso_local local_unnamed_addr global i8 0, align 1
; Function Attrs: nounwind uwtable
define dso_local i32 @main() local_unnamed_addr #0 {
entry:
%tmp.sroa.4 = alloca [6 x i8], align 2
call void @llvm.lifetime.start.p0(i64 6, ptr nonnull %tmp.sroa.4)
%f.val = load i16, ptr @f, align 8
%0 = getelementptr i8, ptr @f, i64 8
%f.val4 = load i64, ptr %0, align 8
%call = call fastcc { i16, i64 } @j(i16 %f.val, i64 %f.val4)
%1 = extractvalue { i16, i64 } %call, 0
%2 = extractvalue { i16, i64 } %call, 1
store i16 %1, ptr @f, align 8, !tbaa !5
call void @llvm.memcpy.p0.p0.i64(ptr noundef nonnull align 2 dereferenceable(6) getelementptr inbounds (i8, ptr @f, i64 2), ptr noundef nonnull align 2 dereferenceable(6) %tmp.sroa.4, i64 6, i1 false), !tbaa.struct !9
store i64 %2, ptr getelementptr inbounds (%struct.a, ptr @f, i64 0, i32 1), align 8, !tbaa !10
call void @llvm.lifetime.end.p0(i64 6, ptr nonnull %tmp.sroa.4)
%conv = sext i16 %1 to i32
store i32 %conv, ptr @i, align 4, !tbaa !12
%call1 = call i32 (ptr, ...) @printf(ptr noundef nonnull dereferenceable(1) @.str, i32 noundef %conv)
ret i32 0
}
; Function Attrs: mustprogress nocallback nofree nosync nounwind willreturn memory(argmem: readwrite)
declare void @llvm.lifetime.start.p0(i64 immarg, ptr nocapture) #1
; Function Attrs: nounwind uwtable
define internal fastcc { i16, i64 } @j(i16 %q.0.val, i64 %q.8.val) unnamed_addr #0 {
entry:
br label %for.cond
for.cond: ; preds = %for.body, %entry
%storemerge = phi i8 [ 5, %entry ], [ %add, %for.body ]
store i8 %storemerge, ptr @d, align 1, !tbaa !14
%cmp = icmp ult i8 %storemerge, 6
br i1 %cmp, label %for.body, label %for.end
for.body: ; preds = %for.cond
%0 = load i8, ptr @h, align 1, !tbaa !14
%conv2 = zext i8 %0 to i16
store i16 %conv2, ptr @f, align 8, !tbaa !15
%1 = load i8, ptr @d, align 1, !tbaa !14
%add = add i8 %1, 1
br label %for.cond, !llvm.loop !17
for.end: ; preds = %for.cond
%.fca.0.insert = insertvalue { i16, i64 } poison, i16 %q.0.val, 0
%.fca.1.insert = insertvalue { i16, i64 } %.fca.0.insert, i64 %q.8.val, 1
ret { i16, i64 } %.fca.1.insert
}
; Function Attrs: mustprogress nocallback nofree nounwind willreturn memory(argmem: readwrite)
declare void @llvm.memcpy.p0.p0.i64(ptr noalias nocapture writeonly, ptr noalias nocapture readonly, i64, i1 immarg) #2
; Function Attrs: mustprogress nocallback nofree nosync nounwind willreturn memory(argmem: readwrite)
declare void @llvm.lifetime.end.p0(i64 immarg, ptr nocapture) #1
; Function Attrs: nofree nounwind
declare noundef i32 @printf(ptr nocapture noundef readonly, ...) local_unnamed_addr #3
attributes #0 = { nounwind uwtable "min-legal-vector-width"="0" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cmov,+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "tune-cpu"="generic" }
attributes #1 = { mustprogress nocallback nofree nosync nounwind willreturn memory(argmem: readwrite) }
attributes #2 = { mustprogress nocallback nofree nounwind willreturn memory(argmem: readwrite) }
attributes #3 = { nofree nounwind "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cmov,+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "tune-cpu"="generic" }
!llvm.module.flags = !{!0, !1, !2, !3}
!llvm.ident = !{!4}
!0 = !{i32 1, !"wchar_size", i32 4}
!1 = !{i32 8, !"PIC Level", i32 2}
!2 = !{i32 7, !"PIE Level", i32 2}
!3 = !{i32 7, !"uwtable", i32 2}
!4 = !{!"clang version 19.0.0git"}
!5 = !{!6, !6, i64 0}
!6 = !{!"short", !7, i64 0}
!7 = !{!"omnipotent char", !8, i64 0}
!8 = !{!"Simple C/C++ TBAA"}
!9 = !{i64 6, i64 8, !10}
!10 = !{!11, !11, i64 0}
!11 = !{!"long", !7, i64 0}
!12 = !{!13, !13, i64 0}
!13 = !{!"int", !7, i64 0}
!14 = !{!7, !7, i64 0}
!15 = !{!16, !6, i64 0}
!16 = !{!"a", !6, i64 0, !11, i64 8}
!17 = distinct !{!17, !18}
!18 = !{!"llvm.loop.mustprogress"}
```
LLVM version: 0f501c30b9601627c236f9abca8a3befba5dc161
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJzsW19v5CgS_zTkBbVl8J92HvLQSTbSSju61e3ppHuKsI272cHgwTjp5NOfAP_BbifTuclJo92OIjdtqF8VRVFVUGrStmwvKL0ByS1I7q9Ipw9S3ZS6OL6-PF_lsny5-Sctu4KWUNNWw4K0FEQ7eNC6aUG0A_gB4Ie9LHPJdSDVHuCHV4Afktek_c9TLL6B8B6EO5CG_b_7iiMmCt6VFILortUlEzo4gOiXt7ql19tq1RUaEgi2t-4NhExolD5qmINofNcxodP4UcNifAm297CCILo3tAhs78ceMzh71LAE-A4extetJpoVcGKJd3unqgEF4LQyNKufHgMmdIQfNWRvYv8JcOYz-gbwtT_HSioIcFZazgmIbqFp3sF0aN6bJ76FCODrgQjCKsht38FTjaK6U8Ix8XQzSgprwgTA2VwCXzhuMY0uIpDce9Bjn5kON5JMfcx2VIG_So1iQleWFwY4KUFyJ2zzDjKfehRvaUr2ectaWmhjpBKCNNyp_e9K1lIzKUAaBrOhtJLK2PA6XHQLv8iy4_TXfonx1hh-UAC87ddNdqqgjxXjVJCa9qPwMAq7UZqoPdWwJJpw8iI7PYyjmxpEO7pp8DYE0S7C9mG-ovlX00pj-9iwsYFwBqIdwtmmysK-JeyrdCBP480fyCnUF0Ur1vBR3GOWPqbxphNfhXwWG85Ed9zsRTdSDVsxccseEEupXxpqTAIylNo1SmM4LY17xqHbY2UrH7ksCId7LnPC4QzMYRhjdSihxcF3kHC2FzAbwdgCzD4fO2GUXz6SslQDPoswDCeIeIQIWq0sSqPYE9EUzqgLKVpNhIYguY3hEbLM7O9iMshwZx5hb5YOHI3g5fnyZb54E8LhBxFGy33oRGFsHu60VsY9QyE78cxECbtnTXJO3diSVkxQj6PRHIhDb9uvyABwFE7ugAqtXsZtZDZ-ousmaJUkQWwnRLgBMVpNB61OsuOBriCcwyfJSiMA5091wFlFNatp0GqidNCEAGfGQqzBNVpBIYXoOJ-z9JwewIlFNULYRkVaXRQrdmt4GkflUDtR0mpCj8NqDhpaRHrUihT6ifBubSsM3M2r0CNGHyVGA3GrpaJ2sxgZBiU48abtYmMO0jkx_hklb6u3pnXRvARNaP6NY1mffr9MsKSKVlRRUVBrQDhLjX3sqaac1lRoQ8xEbshbE6BYthTRTA4bVY7r9yFWi2V2eE5rCFaEt7TH7ucf9IEKYHS90KHRMk7QIMjbk_Bc1dps7CqYTYN61uurgMIzrJyK8n-0cSmerFG19KhH-zAhkEV4MXGzvx2FNx3m-8qF5HixmdC0mxyYMRpDFASBXaQ4HEP52hqfri3qycxyDeocqEZZr72Upffvi3TgHedXd61ulNwr2rZQGIfGc1J8hUJWilIoZPsiislFPjPO-8yoprVULwBnRO1ragI2VJSUz4ppOgpV0oITRc9zXqyuicmOh9UtSKM7RZ19Rz_qyZnQVAlytqfruY_6NpOTgr8Yxdu883zHnyvISU6tpVZSBYUUpT-b8V1k09Gz_owGGkXNVrTZigU2hxFnpYkTYTJQa-Q1VXuX3jQHZiIlSG5h4lPAPgKZDoATUpZ97wBvB8w3TjbH93ZP6Qfixe6J_d1TN1YqZhod16uY6UCQK-PVHJnpmOl2UMHsJT3Vtx33o_qeFtILflySEs48_OFcNUjxhC3Gq3VX2eStULoa6izFeeFuindjpD2V9NwFI6VL6cynExPN4vGqxTs85wKkbCzodrku1G2Dc9StqEkSnN8PgzAoZPNipzTNDY3Bwu3a7-YCC1icBGHwLTBbPAgD--6RlUd3sluPjJ4-e5bGvWTvMVgRPI09lDMkOifAApwEVWF0xURLlTtuueabyVYjWSuFSyTS95Tu53IDI_QBRkvhxr539DUzORP93sEdZPnM2PiZQfHNlJNwRlovHlksE4imQLkcMoSqXg99GjiEVxtN8U-eGswyvk9IDGYrNhdgCPD9AW-Ror2VBnh53fo5MPLFIlorlneatn2m4G7GTjIWCDCumdhwuid880QLLdXmmZX6YE7W0T3A2JyxzTAhN1qRpmFiv6mJN0CrjvZjWk2Kr5tGSe2Q8q6qqNq07JWOw7N-rLsC2RRNN3Yds3RjzMfvrygx-mjHQQDfFrU0ObNpHTPXqI6tcq26PrpGaw4hfQO71jHbDuidoDPeeyqoYoXtHjbrXIto1OL_zVLfYo3PZ_1pPCPPaObYf09jGC7fXEJR2wvJoOJkP6QMyF49o7CPh0M-g_vPaELqMVhJhZ4Tx6fsQm9Ef7y1eADj5-JA1OOg0P68Fvt80II4m4h___UO_kafKPdosU-LF7Rbn_aX92mjt2mHs9IblPFcIQDjghOxh09UtcbHomuTBuyZNgAeXTKnS3uG6XQ94A1OT5i0B6l0LxPAaLtKtj0hk7VgjdRmHc1aTADZKkB2AvAHqxtO4R3AD8YmAb6F_7rd7RaTu_bVOd602DSvN7YZm5nNmO-DzSC0KtbMTJxcXIr999QxsxDzPRrYROvjoxM2THxX6UuL2L4_emEH3zGEFUsgk0Dp7G5ppr9shuIMo2StZsLdcvXcB2HRfPypHYynlMD38DMzWCuy7CpN1aVwcimcXAonf93CSRU8Eb5-ybC4gVleDS2uDFarANmSU_zWtUB4yurjZZ3-WG85eWdux3k-7w-XZ_ybB_w5tR10qe38cG0H_4VrO-hS2_k5LnB-0tpObybfgnDh8L4FmXvzkcLOpbJzqexcKjufX9n58TKFt8FP6h-fVJYYPcalCHEpQlyKEH-Xe-dLEeJShLgUIS5FiEsR4lKE-DmLEL_99u8vw9Ywjj2skhAVUZhfpyFK8bbAUVpdk7wgGYlyWuUkKQuUoqvyJiqvo2tyRW_QFoUoC69jfHW4ybc5iSoSxjhMKI5wgaoojKqizOOwSOPtFbvBIY7DCCGUoSTGQZrgjJAiKjENaRZHIA5pTRgP7JSk2l-xtu3oTRZn4fbKHiha-wMrk3m0hawbxon9aQp2jtnqAkQ72WhWs1fbZzWR3F-pG9O5ybt9a1I41up24qOZ5va3W7MfvCT38MvAh0Ki4eYf0VWn-M3iR1tMH7o8KGQN8IOVwH2YAPYnLTTAD3YeLcAPdir_DQAA__9oBjOz">