<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/83557>83557</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            [Flang] don't mix rewrite and conversion mlir APIs in the same pass
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            flang
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          tblah
      </td>
    </tr>
</table>

<pre>
    In https://github.com/llvm/llvm-project/pull/83253 @matthias-springer pointed out that we should not use rewrite patterns (`mlir::OpRewritePattern`) with the dialect conversion pass driver.

Either all of the rewrite patterns should be changed into `mlir::OpConversionPattern`s, or the passes should use a driver intended for rewrite patterns (`GreedyPatternRewriter` driver or manual IR traversal).

On a quick glance, this applies to a significant number of flang passes. We should fix these. I fixed the pass with the original issue here: https://github.com/llvm/llvm-project/commit/44c0bdb402271522a17704b4a18c8bf5efb55c4f
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJyUkztv7DgMhX-N3BAZyPK7cDGb7CymSpBma9qibe3Kkq9E5_HvL-yZTO4Dt0jjByAdno88xBjN6IhaUfwliocEV558aLmzOCWd1-_t2cHEvESRHYU6CXUaDU9rd-j9LNTJ2peP190S_H_Us1CnZbVWqFOdqSIDkcsZmSeD8S4uwbiRAizeOCYNfmXgCRleCeLkV6vBeYY1EgR6DYYJFmSm4CIIVYtSztaEzUt2fFyeL0eeLidEKYVq4NXwBDwRaIOWeobeuxcK0XgHC8YIOpgXCgchH4Q8Xp5_G54oAFoLftgv_1b96q4j6Cd0I2kwjj384uj-VuvTVBTqHnzYZTcDdBPbMPHqZ5Mjp0nD4MOf4P8JRPr9Kn2lD6KUHxo-wIxuRQvnZ-CAmxe0QjU_0T46QPi2mv5_GC26njaDPJkIuCzWUAT2gLAlwwymR8fg1rnb9AcYLLrxynGAf29jG8zbRhjpAOfth_QN-HMkPpjROLRgYlwJJgoksuPXA9b7eTbbR573stNdLpWq0kIpTKtK5l2Oad3X3VDQ0BVFnw-JbjPdZA0m1KaVbFSj8lwmU6vKbtClykvUWV8OaV0hynIYMK0G1LJMTKukymUm0zRVlZKHNGv6omiorIkqpVDkkmY09rB5PPgwJjtcW2dFUSUWO7JxXy-l9t4JpbZNC-3O1K1jFLm0JnL8VGDDdt_J036jeADtnVAVw2zebuFAp38M95ZDOD6dIxi3dzvifBlAsgbbfrnJO0bc97goqu8BAAD__4d9ZLQ">