<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/83028>83028</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            [clang-repl] VarDecl emitted outside TopLevelStmtDecl
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            new issue
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          weliveindetail
      </td>
    </tr>
</table>

<pre>
    Works:
```
$ clang-repl
clang-repl> int a = 42;
clang-repl> int i = 0;
clang-repl> for (; i<42; i+=1) a-=1;
clang-repl> %quit
```

Fails:
```
$ clang-repl
clang-repl> int a = 42;
clang-repl> for(int i=0; i<42; i+=1) a-=1;
clang-repl: llvm-project/clang/lib/CodeGen/CGDecl.cpp:161: void clang::CodeGen::CodeGenFunction::EmitDecl(const Decl &): Assertion `VD.isLocalVarDecl() && "Should not see file-scope variables inside a function!"' failed.
Aborted (core dumped)
```

Other side-effects include incorrect behavior for definitions inside `if` conditions:
```
$ clang-repl -Xcc -Xclang,-ast-dump
clang-repl> int *a=nullptr;
TranslationUnitDecl 0x5555d8962468 prev 0x5555d893e690 <<invalid sloc>> <invalid sloc>
`-VarDecl 0x5555d8962518 <input_line_1:1:1, col:8> col:6 a 'int *' cinit
  `-ImplicitCastExpr 0x5555d8962590 <col:8> 'int *' <NullToPointer>
    `-CXXNullPtrLiteralExpr 0x5555d8962580 <col:8> 'std::nullptr_t'
clang-repl> if (auto *b=a) *b += 1;
TranslationUnitDecl 0x5555d8962608 prev 0x5555d8962468 <<invalid sloc>> <invalid sloc>
|-VarDecl 0x5555d89626c0 <input_line_2:1:5, col:13> col:11 used b 'int *' cinit
| `-ImplicitCastExpr 0x5555d8986b10 <col:13> 'int *' <LValueToRValue>
|   `-DeclRefExpr 0x5555d8962728 <col:13> 'int *' lvalue Var 0x5555d8962518 'a' 'int *'
`-TopLevelStmtDecl 0x5555d8986cb0 <col:1, col:22> col:1
  `-IfStmt 0x5555d8986c70 <col:1, col:22> has_var
 |-DeclStmt 0x5555d8986c98 <col:5, col:13>
    | `-VarDecl 0x5555d89626c0 <col:5, col:13> col:11 used b 'int *' cinit
    |   `-ImplicitCastExpr 0x5555d8986b10 <col:13> 'int *' <LValueToRValue>
    |     `-DeclRefExpr 0x5555d8962728 <col:13> 'int *' lvalue Var 0x5555d8962518 'a' 'int *'
 |-ImplicitCastExpr 0x5555d8986bb8 <col:11> 'bool' <PointerToBoolean>
    | `-ImplicitCastExpr 0x5555d8986ba0 <col:11> 'int *' <LValueToRValue>
    | `-DeclRefExpr 0x5555d8986b80 <col:11> 'int *' lvalue Var 0x5555d89626c0 'b' 'int *'
    `-CompoundAssignOperator 0x5555d8986c40 <col:16, col:22> 'int' lvalue '+=' ComputeLHSTy='int' ComputeResultTy='int'
      |-UnaryOperator 0x5555d8986c08 <col:16, col:17> 'int' lvalue prefix '*' cannot overflow
 | `-ImplicitCastExpr 0x5555d8986bf0 <col:17> 'int *' <LValueToRValue>
 |   `-DeclRefExpr 0x5555d8986bd0 <col:17> 'int *' lvalue Var 0x5555d89626c0 'b' 'int *'
      `-IntegerLiteral 0x5555d8986c20 <col:22> 'int' 1
clang-repl> if (auto *b=a) *b += 1;
In file included from <<< inputs >>>:1:
input_line_3:1:11: error: redefinition of 'b'
    1 | if (auto *b=a) *b += 1;
      |           ^
<<< inputs >>>:1:1: note: '' included multiple times, additional include site here
<<< inputs >>>:1:1: note: '' included multiple times, additional include site here
error: Parsing failed.
clang-repl> %quit
```

I guess the `VarDecl 0x5555d89626c0` for `b` should be emitted inside the `TopLevelStmtDecl 0x5555d8986cb0` or even inside `IfStmt 0x5555d8986c70`.
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJzEWN9z2jgQ_mvEiwZGln8_8EAg9DqTuXbaNNe3jGyvQXdC8kkybf_7G8kmGGJC0s5NMwTbsvztt_utrF2YMXwjAeYovkHxasJau1V6_g0E3wOXFVjGxaRQ1Y_5X0r_Y1C4QGSFyAIlpP90lzTCpWByM9XQiG5scB3eYi4tZhiFKxxRFN5cmsL9FHJhRq00RjRD4Q3mKFx6JMwRvUHhKkA0x2zqz8afRjT-t-V23AH_vWZc_L8-1kojmnlPUbgiP-XJAgux300brf6G0iK69jcRXQteILpeqgregXRn71ZQilnZNChcBEngHt0rXnVuOD_DxWH28GLdytJy1Q_e7rh1OIhmpZLGYneBEU0QzR3iwhjQbjpGCXlYzbi5UyUTD0z3Tzl3_PQEI0o_b1UrKiyVxQYA11zA1JSqAbxnmrNCgMFcGl4BZrg-MKEBohTRFNeMC6hmXVQWhdIWKuypacBVu2ugcrwua_zBbkFjhz-FuobSOnOlaCtwR6U1lBYXsGV7rrTPuApqLrmj8cQMJYTXKCG4VLLqbr0ubfD0a1m6r06y5ZQZO3W0L-UToguGwpVshWisfsqHe82kEcxZ_iI7fTD5HsdxXGV5QqMkw42G_XEshCQnGIVLFC653DPBK2yEKlF469fG89GDM9NeySF-HGTdI01rHwWX8OiSq_unS1wql6aZA-5OE7cuaNo75HQsXUg7G9iFc_p-1whecrtkxt5-b_SJuY76APYUDIXLP1sh7tVHxaUF_UQf4w58-fWrm_DR6jtuQTPxzEI2YsHYqlsCffQfLaLpqFC1S0HWWuUYFShcsS7pFwXu1jQOXitdQs6l6-R8u3Tpcky6pCRn0tFeuvgoXRAetQsC3BqocHFZQZQur2iYJUUwiHCH_0zEuwcmWrhXn_xx6Emvo3PmE9Tn6qU0exlb7B0gfmD6WRbTlHnrw_nH3L9XzR3sQXy2uzOlsqQshh4dg0fpIHgnKV47mBOI9CWILTOPe6Z7CKeno_AMIx84f67hYBn0Gl1OiXGE12fBwcq19fxLuXA08hsywmvwomPF0GzQmy2UEr1X_QvqXt0oJYDJUYletMDIiIU3he5i2LKkyK6gj4fNJxBNi0thO7yF1a5RrawWvur80IBmVp3YL6Oh_eR8QXTYAx7OhH-_ujEH31q4--Pz_Y9uqJ_c3_gEphX29N6RoI_N9Itk-scoM5KNMwvSUWaNhpp_7wh2C4VJV_OoPehaqG_HhLoueT0MSvomya-8OrOkqK6A_7Ti_WtAWtjAYds9iSgdWD7XN_jlbfa99LXlobircK3Vrt9FUbjEfgM0uNtE_cdvgt3Dg90xPBQ2vnwGrZV2JxqOZSFW9SEYR_cDH_s3UX5KQ3z8Q_FhE7zG3POTyoI7-rxLj87vWmF5IwBbvgPjspdVXeHKxFP9a7gFvAUNv8viU3Q_Mm243JxW-2_t5t7jTQvGYLv1Bfv4xueKeN9WJqRw56ZrTwrAsOPWNRd9yd-jXCkIHITSGPYgB73C6MaPEjKbVPOwysOcTWAepCTLkyhPosl2XkeMVCnJqzwKI5qlaR4GrCBBSVKWFyWZ8DklNCKUJkFCcxrNYhKxisZpROO0CKIKRQR2jIuZaxZnSm8m3JgW5llIaDYRrABhfNtPqYRv2N90PVa8mui5bzCLdmNQRAQ31hxRLLfC_14wkCNe4UN0D1FTrfXen8dr0mox31rb-IaJrhFdb7jdtsWsVDvXw4r94TDocD07g-jas_8vAAD__yTDuvc">