<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/79705>79705</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            flang/lib/Lower/OpenACC.cpp:3211: possible performance problem ?
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            flang
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          dcb314
      </td>
    </tr>
</table>

<pre>
    Static analyser cppcheck says:

flang/lib/Lower/OpenACC.cpp:3211:53: performance: Function parameter 'declareGlobalName' should be passed by const reference. [passedByValue]

Source code is

static void createDeclareGlobalOp(mlir::OpBuilder &modBuilder,
 fir::FirOpBuilder &builder,
 mlir::Location loc, fir::GlobalOp globalOp,
 mlir::acc::DataClause clause,
                                  const std::string declareGlobalName,
                                  bool implicit, std::stringstream &asFortran) {
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJyUU01vnDAQ_TXDxcoK7HVgDxz2Q_QSNYdIvY_tgXVrsGWbVPvvK9iku00rteXAMJrH473BD1Oyw0TUgjyAPBU457OPrdFKVNtCeXNpXzJmqxlO6C6JItMh6DPpbyzhJYHYQ3mC8u3eO5wG4J2zCnj35L9TBN49B5r2x-NGhwBiL3hVgdhLAWLPAsXexxEnTUvbzZPO1k8sYMSRMkUGvDakHUb65LxC9xlHAl6zdPazM0wRC5gSGaYuTPspZRapp0iTpg0DebhOD5cv6GYCebqX--LnqIlpb4jZdD9JV9Ov3hqmI2Gm072I5wC8GZ2Ni3-xfw6H2Tqzqn0cvXnrgB-vbKx_R3Y2_gJWH5E30ievcd2F8xr48cbxLoENP7X8_jZqfX04YcajwzkR02u5of96XfeZsrlSpRztNLA__I5_ZlTeO2bH4Ky2eXH1gTzlSDgum8HU-ZgjTsB3DOpDYVphdmKHBbVVXT6KppKVKM5tLSuiBpF4yftaqF42RtZb3ewqIUqpCtvykm_LitdVIyvJN2VDVG6bXj2SKne4g21JI1q3ce513Pg4FDalmdp6V5eycKjIpTUgnL8dcL5kJbYL_kHNQ4Jt6WzK6caQbXbU_kceWPApWeXoPhMsRK8cjQxEV8zRteecwxo63gHvBpvPs9poPy7fcK_v5SFE_5V0Bt6tThLwbjXzIwAA__-nEDVF">