<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Issue</th>
<td>
<a href=https://github.com/llvm/llvm-project/issues/76687>76687</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>
[mlir][spirv] spirv.interface_var_abi is ignored in ConvertGpuLaunchFuncToVulkanLaunchFunc
</td>
</tr>
<tr>
<th>Labels</th>
<td>
mlir:spirv
</td>
</tr>
<tr>
<th>Assignees</th>
<td>
</td>
</tr>
<tr>
<th>Reporter</th>
<td>
python3kgae
</td>
</tr>
</table>
<pre>
The following test will fail with output [0, 0, 0, 0, 0, 0, 0, 0] when expected [3.3, 3.3, 3.3, 3.3, 3.3, 3.3, 3.3, 3.3].
```
// RUN: mlir-vulkan-runner %s --shared-libs=%vulkan-runtime-wrappers,%mlir_runner_utils --entry-point-result=void | FileCheck %s
// CHECK: [3.3, 3.3, 3.3, 3.3, 3.3, 3.3, 3.3, 3.3]
module attributes {
gpu.container_module,
spirv.target_env = #spirv.target_env<
#spirv.vce<v1.0, [Shader], [SPV_KHR_storage_buffer_storage_class]>, #spirv.resource_limits<>>
} {
gpu.module @kernels {
gpu.func @kernel_add(
%arg0 : memref<8xf32> {spirv.interface_var_abi = #spirv.interface_var_abi<(0, 3)>},
%arg1 : memref<8xf32> {spirv.interface_var_abi = #spirv.interface_var_abi<(0, 4)>},
%arg2 : memref<8xf32> {spirv.interface_var_abi = #spirv.interface_var_abi<(0, 3)>})
kernel attributes { spirv.entry_point_abi = #spirv.entry_point_abi<workgroup_size = [1, 1, 1]>} {
%0 = gpu.block_id x
%1 = memref.load %arg0[%0] : memref<8xf32>
%2 = memref.load %arg1[%0] : memref<8xf32>
%3 = arith.addf %1, %2 : f32
memref.store %3, %arg2[%0] : memref<8xf32>
gpu.return
}
}
func.func @main() {
%arg0 = memref.alloc() : memref<8xf32>
%arg1 = memref.alloc() : memref<8xf32>
%arg2 = memref.alloc() : memref<8xf32>
%0 = arith.constant 0 : i32
%1 = arith.constant 1 : i32
%2 = arith.constant 2 : i32
%value0 = arith.constant 0.0 : f32
%value1 = arith.constant 1.1 : f32
%value2 = arith.constant 2.2 : f32
%arg3 = memref.cast %arg0 : memref<8xf32> to memref<?xf32>
%arg4 = memref.cast %arg1 : memref<8xf32> to memref<?xf32>
%arg5 = memref.cast %arg2 : memref<8xf32> to memref<?xf32>
call @fillResource1DFloat(%arg3, %value1) : (memref<?xf32>, f32) -> ()
call @fillResource1DFloat(%arg4, %value2) : (memref<?xf32>, f32) -> ()
call @fillResource1DFloat(%arg5, %value0) : (memref<?xf32>, f32) -> ()
%cst1 = arith.constant 1 : index
%cst8 = arith.constant 8 : index
gpu.launch_func @kernels::@kernel_add
blocks in (%cst8, %cst1, %cst1) threads in (%cst1, %cst1, %cst1)
args(%arg0 : memref<8xf32>, %arg1 : memref<8xf32>, %arg2 : memref<8xf32>)
%arg6 = memref.cast %arg5 : memref<?xf32> to memref<*xf32>
call @printMemrefF32(%arg6) : (memref<*xf32>) -> ()
return
}
func.func private @fillResource1DFloat(%0 : memref<?xf32>, %1 : f32)
func.func private @printMemrefF32(%ptr : memref<*xf32>)
}
```
The issue is caused by ConvertGpuLaunchFuncToVulkanLaunchFunc ignored spirv.interface_var_abi and lost the information
while SPIRVLowerABIAttributesPass translated spirv.interface_var_abi into things like bind(0,3) in spirv
```
spirv.GlobalVariable @kernel_add_arg_0 bind(0, 3)
```
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJy8V11vozgX_jXOjRUEdsjHRS7apJkZzbyvRp3Z3iIDDnjj2Mg2Sbu_fmWbBEihM600W0U0wc95zvexTbRmhaB0DeJ7EG8npDalVOvqxZRS4ENB6CSV-cv6Z0nhXnIuz0wU0FBt4JlxDveEcXhmpoSyNlVtIIjvQ4A28FePeAvPJRWQPlc0MzS3gjjAdhF-5H-8DUC4BeFd85yHzaf7Eu0A2sHHv_4P8B08cqamp5ofiJiqWgiqIECxhtOpLomi-ZSzVAO8BShuUYYd6fSsSFVRpQHaABRbnsQTJLVh3DJQYdTLtJJMmKmiuuYG4O1JshyCxQbuGKebkmYHp3DAws3nh81Xa-N4UH4vJp71KPOaU0iMUSytDdUQLO79EiyqOsikMIRZ-z3S-uVXoa6YOgWGqIKahIoTBHgLAcK37wG-iFwXTxkFeHOKApdxEN__KElOlbWq-f39Kfn6-THRRipS0CSt93uqrj8zTrS2aPzgBC68impZq4wmnB2Z0VYzfrAfH8HFtuOdc69xH8zCA1WC8q770EP2tchaQELyHKBlC7n-ARQTVYTQ1Q89KroHeLN83mME8IOl9SYyYajak4wmJ6ISkrJ-2F4tWx_Q0sUJA7Syzix8lMZMiP6gCbMhE7xa9B95vuo67pNyU75NZbpGS1yjvdZ2swjw5izVoVCyrhLN_qEeHd9HVn3z8PXWL6Im7KHD23JJucwOCcvh8w0kchAfn4BLkl8qxo5XFLuxNxjBGx40whO9kwc7HqKYKQOS53tno--m2OfSinVkGpW2B6kjaMA29-_RbaOkqKmVaN_azDY_rl8vL2wDXrvwSJiw_YdW_Sy03XeNDeFcZhfs20a1jfNxafRx6bCTikwKbYgw0E8S1s3BtYpuoNEgFA1B0SD0RHhNh60IwptauMCHLQmi16VzkRg2KBgoNh9R3I1oRrT5xYw1sn0J8K4faS86G6Ecm5lvUl4NjUdYx0bir1gzwrkt9j3j_LHZ0qLtjktiXE254DTd53NxqTOAlkPMaOPii1Zw6kayK8z36Zt19aE_ry_u6gs_rq9Nf6bNW90jcvrcS2ymzXIIv3yFtxONk1pkZdI_LWiA7-ynd3ro7dtuu9CQCW-0U9p4bu3tfV1BUypK8j48GoX3NRFV6Gt0R1qonegjDdEZ-WOA1W13zEe6I-4ztOns9we6G-2PSjFh_ueQO5v-xrn5YLW0PGNl2d-U2i2p3YAqxU7E0DdrNxxzq4ldOyCvugcVDDlXGXXD3vXqesrtXRvG7zz24sa0ru0TZqTWNIfpC9xIcaLKfKrqb66md7XIfsond89p30BWCKloDscOd0TkkEttoLFqxF6qIzFMiubUeC4Zp_DH9y-PT9_kmaq7-y9311Pcd6I1NIoIzYl5QwcTRkJTMlFoyNmBwpSJvDk02jOjbRQnOxgFz_qJy5TwJ6IYSbtXAdurCVFFEnZZ_VG0zzbJ1zhf4RWZ0HW0CGcRjmbL1aRcz0mGSBbOM7xcLpYpni-yRRivViFNUZzjeMLWKESzMAqjaBFHaBWk8SyNsiXFMxSniIRgFtIjYTzg_HQMpComLmHrxXy-XEw4SSnX7n6OkL1rAuydAgjZG7taW7FpWhcazELOtNEtkWGGu7u9E4y3IPbndHuGG423vqadid8slEmt-Lo0pnLD0F1iC2bKOg0yeQRoZw1q_k0rJf-mmQFo59zUAO2cp_8GAAD__2WLuXs">