<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Issue</th>
<td>
<a href=https://github.com/llvm/llvm-project/issues/72406>72406</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>
Add more tests for begin and end in std::ranges::take_view for non-simple-views
</td>
</tr>
<tr>
<th>Labels</th>
<td>
new issue
</td>
</tr>
<tr>
<th>Assignees</th>
<td>
</td>
</tr>
<tr>
<th>Reporter</th>
<td>
hawkinsw
</td>
</tr>
</table>
<pre>
It seems to my naïve eyes that there could be additional testing of the begin and end member functions for take_view over a non-simple view.
1. It looks like there are no tests for this condition in `end.pass.cpp` (https://github.com/llvm/llvm-project/blob/main/libcxx/test/std/ranges/range.adaptors/range.take/end.pass.cpp).
2. It looks like there are type-level tests for this condition in `begin.pass.cpp` but nothing functional (https://github.com/llvm/llvm-project/blob/main/libcxx/test/std/ranges/range.adaptors/range.take/begin.pass.cpp).
To reiterate, my eyes are very naïve and I could be missing something stupid. Please forgive me if I am! However, if there is a need for additional tests, I'd be happy to add them!
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJzEU82OozgQfhpzKQWBCUnnwCHbLbS57WHvqzKugDfGRi5DOm-_MklvlJZGoznNBSz_VNX3h8ymd0SNqP8Q9UeGcxx8aAa8Xozja6a8vjWnCEw0MkQP4w0civdKHNuFgG7EEAeMEAcKBJ2frQZFgFqbaLxDC5E4GteDP6dLoKg3DtBpIKdhpFFRgPPsunSd4ewDRLzQP4uhK_iFAiA47zZsxskSpO1cFB-iON6_ZQ6nCNb7C4M1F3pMgoHA-bX5o-hgGDrv7nOBcSB2BTmdT8icd9MkdgUI-TbEOLGojkK2Qra9icOs8s6PQrbWLl-_zRT8v9RFIVtlvRKyHdG4dGhU9_kpZJs6C9ly1EK2AV1P_LXIUeMUfXhuJMRCti_jyEMOd4jyxxDjbaKNpYXsz6CuvL-AVXME5-OQxPkSAO3v5uDbnE8W7t-_PQQykQJGEvI9-XE1YSJjofDizmSy09OTo2FOWNmPdEfNcZ6MzuEvS8iUuOvNQjASmDOcAEchS_jTX2mhkJqZ84N6w8mVRHrl-5vZOV09Cblfuw44TbeUHNQ6vU41M91U-lAdMKOm3BdFsZPbQ50NjUIskLCqar2lsjtolLjvlCzeuqrYos5MIwtZlWVZl3W1rev8vMcSSyXf9lWn6jOJbUEjGpsnhXIf-swwz9Ts5bbYZRYVWV7DLqWjK6yHQsqU_dCsqqq5Z7EtrOHIzyrRREvNUWsYffLd_2Z7zbNxkNSujqI6PgRf189IpzfPPG_SHmdzsM0vm26dPflnxfZfAAAA__-vzpum">