<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Issue</th>
<td>
<a href=https://github.com/llvm/llvm-project/issues/72194>72194</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>
[mlir][sparsifier] potential bug in `isAdmissibleBSR`
</td>
</tr>
<tr>
<th>Labels</th>
<td>
mlir
</td>
</tr>
<tr>
<th>Assignees</th>
<td>
aartbik
</td>
</tr>
<tr>
<th>Reporter</th>
<td>
makslevental
</td>
</tr>
</table>
<pre>
Just happened to notice [this](https://github.com/llvm/llvm-project/blob/e9453f3c3c7e682e39952c9e18e6b1f8152b0ffa/mlir/lib/Dialect/SparseTensor/Transforms/SparseGPUCodegen.cpp#L439C7-L439C7):
```cpp
if (...) {
// CuSparse only supports "square" blocks currently.
SmallVector<unsigned> dims = getBlockSize(aTp.getDimToLvl());
assert(dims.size() == 2);
return dims[0] = dims[1] && dims[0] > 1;
}
```
probably should be `return dims[0] == dims[1] && dims[0] > 1;`?
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJyUU0GvpDYM_jXmEi0ChwA5cNgZdipVe6g6094TMEz6AqFJeNLrr6_CzOtuV3t5EiJybH-f7fhTIZh5JepAnABRKR-1eQFEEH2m9nh3vlvUS7D0SmtUNtNufOt-3UNkd7VttNLIomOri2YgBuIU7yaA6AHbe4xbAP4Z8AJ4mU287zof3AJ4sfb1_fi0efcXDRHwoq3TgBeSleATH_jQUN0icSkFDpLKlmpdTm0pUBfTpAAvizU-4ZiU1xtlH0DXTflAN1qDS-6bV2uYnF_Cf75ffvvj7Eaaac2HbQPkXysuz82nxwEoU91FD8X7vy4eX4o-bpiZGGCb5zmgZNCcnteMsUfD7Lw_uJhb7RsL-7Y5HwMDxPD3rjwBItPWDS-BDbv3tEb7lj9Rrouy9k8aovPAz_t6PNII_AsbzRIY8J7NFE8p-2r-IcBW3bZ8ptib5ea-vlrANnWRGnmvTIVAPgK2CSIPj7SjeN4nQPxfNGPMU9z9ejCCOBUg-oP4aZeHjTVg_UPIF1Z-w4Gm_2GE3891804rncZzd7sdmSYGdfFz4o9w1wXwC_ueKRs7PkouVUZdWUspUXIhsnuHistCDZXUo5TUlIOsqCymASfk2AxNZjoskJdlWRXIhRB5K4UoeCs5n2pe6xqqghZlbJ72OXd-zkwIO3UNlrLKrNJkw1Nfj4U9xOW7Y_31PgeoCmtCDN8Aoon20OSRIHoQp5CWyUyGks02F2mNRlmm95mZNY3NhM_jYkIw2tLp-jvURbZ7231Yh0f1SStHA_8GAAD__5FfOBA">