<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/71161>71161</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            [clang] Wrong SourceRange returned by getNameInfo() for template instantiations of CXXDestructorDecls
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            bug,
            clang:frontend,
            regression
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
            tahonermann
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          steakhal
      </td>
    </tr>
</table>

<pre>
    [D64087](https://reviews.llvm.org/D64087) appears to break some downstream code that relies on the expectation summarized in this unittest:

```C++
TEST(Regression, CXXDestructorDeclsShouldHaveWellFormedRanges) {
  std::unique_ptr<ASTUnit> AST = buildASTFromCode(R"cpp(
template <typename T> struct Resource {
 ~Resource();
};
template <typename T>
Resource<T>::~Resource() {}
 
void instantiate_template() {
  Resource<int> x;
}
)cpp",
 "foo.cpp");
  auto &SM = AST->getASTContext().getSourceManager();
 
  auto Matches = match(
 findAll(decl(hasDescendant(cxxDestructorDecl().bind("dtor")))),
 *AST->getASTContext().getTranslationUnitDecl(), AST->getASTContext());
 
  for (BoundNodes Match : Matches) {
    const auto *D = Match.getNodeAs<CXXDestructorDecl>("dtor");
    assert(D);
    auto Range = D->getNameInfo().getSourceRange();
    if (Range.getBegin() != Range.getEnd()) {
      ASSERT_TRUE(
 SM.isBeforeInTranslationUnit(Range.getBegin(), Range.getEnd()));
    }
 }
}
```

The test describes that for all `CXXDestructorDecl` the corresponding `getNameInfo()` should return a `SourceRange` where the begin location is before then the end location (if they were not the same of course).
This test passes before commit 256a0b298c68b89688b80350b034daf2f7785b67 `[clang] Correct source locations for instantiations of function templates.` (2023.09.12) but breaks after that.

IMO this expectation sounds right, and I believe it should hold.
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJx8Vk2Po7oS_TXOpjQRMYHAIgs6dPR60fOkTkYzu5GxC_AbsPNs0x93cX_7lQ0k6WTmSiggV6Wqzjnlspm1slGIW5I8EEoda7VC0zOlCKUkKRdscK02W-uQ_WpZt6i0-PDOZbqOsg1JSkKz1rmTJXFB6J7QvcFXiW922XWv_VKbhtD95ExzYKcTMmPBaagMsl9gdY8g9JuyziDrgWuB4FrmwGAn0YJW4FoEfD8hd8xJrcAOfc-M_AsFSG-VFgYlnUPrfBVRSaL5N43GZ0fog3_C6vHxcCQ0e8HGoLVSK0J3sPvxo0TrzMCdNiXyzh5aPXTiP-wVv2PX7bXpUbww1aD1SMhmigZgnfB542JQ8v8D_jw5Q-JdcTh-U9KR-BGKwxFIXEI1yE4Uh-Pe6H6nBfoiCKX8dCI0G6M57E8dcwgk3rmPEyrWIxx9kLE2eEGrB8PxqoC_5zUfheYkngxkU56__xh3NJ8jxLuwGODcxA0ZN-WUdHy9aulFsI4pJ5nDn3Oeq79MLF2lkCrQ8v6p0vGD5oENSuhuTkRprfVyXr7AA2CD00BoengO9BaH4xcSPzboisNxp5XDdzfWsWzQHUL2Z6ZYg-aGKfgU8Zk53qINMXv_fVYHaqlE0XWEZgK5f7XMlmg5KsGUT8bf3z-30VRAJZUIn1Q4bSYkl-cCtvh3FEfDlO3CPvDddcnge_jPf_0t2FobIDR70IMSX7VAOyIHEhczBzcaAnCtrJuJL8rAUfD1xfkghSXx7m4z-Z66RR9fhWXWovG1lncWnypsu5CrnAB-ZT0-qVrf6hs8b9UFAFl7qMHqnR-wkWruUbrykc-2x0mp_A48QHE4PL4cfx5fvj1emuLwvJT2AWtt8EndCPSHpF6t3ya8rftqw533yPljnm7XI-_YIvhJCAItN7JCO45TLzbrOvDD8E6dNApDlmtj0J60ElI13vOOaO9pw1wEg24wCpj3u-Y-jeCtRYMhYuUhQ6f5OLmlhSrw5I3TYFfiYic0k7Vf_oA3H0JpF5ysn1a6Bq4HY9ELPoOVdkR78h10js5130sHNElZVNE842lWZXmaZVUWxUlURfFasJrWm02WVOnGQyDJA--YakhSws7zwB1Mk3YuzwYSL9MuLOka6kHxUP48_OzSs0BoRiMaL6N8ufIND9XgxlPPAqsdmiDM8lq8p-f_jufZp-PO708LRjat833DlIAnqPzx-Iog3SxIqzuxXIhtLPI4ZwvcrtI8j6L1ahMt2u2mikW-zpHnUVRz5HVSZxsa8zzJkoSnq4Xc-mpXqyiO8jhdRUtcRZhXUZaI9boSa07WEfZMdueTfSGtHXC7Wa3S1aJjFXZ2ukdUQzPNcEpHVuOiNn4g-VafDObq_A13DbP1kb9UQ2PJOuqkdZdbxMJJ14Vrylml70arBq5ab2pJFFB9wF3rBvHOx-C9ivcXgMVguu3ny00jXTtUS657Qve-tun15WT0_5A7QveBFEvoPvDyTwAAAP__IqffkQ">