<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/70453>70453</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            [lldb] Possible design issue when using Python >= 3.12
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            new issue
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          tuliom
      </td>
    </tr>
</table>

<pre>
    While trying to update lldb to work with Python >= 3.12, I found the following issue:

Starting with Python 3.12, there is code now preventing the usage of `PyImport_AppendInittab` after `Py_Initialize()`.
However, according to [this source code comment](https://github.com/llvm/llvm-project/blob/7a1e8783586ecc90ee15f12c7b76799313bb32e8/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp#L88-L90):

```
We cannot control what external code may have done before getting to this point in LLDB,
including potentially having already initialized Python...
```

This is causing the following failures:

```
Failed Tests (19):
  lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/0/20
  lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/1/20
 lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/10/20
  lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/11/20
 lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/12/20
  lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/13/20
 lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/14/20
  lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/15/20
 lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/16/20
  lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/17/20
 lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/18/20
  lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/2/20
 lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/3/20
 lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/4/20
  lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/5/20
 lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/6/20
 lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/7/20
  lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/8/20
 lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/9/20
```

With the following output:

```
Fatal Python error: PyImport_AppendInittab: PyImport_AppendInittab() may not be called after Py_Initialize()
Python runtime state: initialized

Current thread 0x00007f60b876c300 (most recent call first):
  <no Python frame>
 #0 0x00007f60b059bceb llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/build/llvm-build.f39/lib/libLLVM-
18git.so+0x79bceb)
 #1 0x00007f60b05992ab SignalHandler(int) Signals.cpp:0:0
 #2 0x00007f60afa089a0 __restore_rt (/lib64/libc.so.6+0x3e9a0)
 #3 0x00007f60afa5a834 __pthread_kill_implementation (/lib64/libc.so.6+0x90834)
 #4 0x00007f60afa088ee gsignal (/lib64/libc.so.6+0x3e8ee)
 #5 0x00007f60af9f08ff abort (/lib64/libc.so.6+0x268ff)
 #6 0x00007f60b435acaa /usr/src/debug/python3.12-3.12.0-1.fc39.x86_64/Python/pylifecycle.c:2712:0
 #7 0x00007f60b435acaa /usr/src/debug/python3.12-3.12.0-1.fc39.x86_64/Python/pylifecycle.c:2820:0
 #8 0x00007f60b435b020 /usr/src/debug/python3.12-3.12.0-1.fc39.x86_64/Modules/faulthandler.c:1035:0
 #9 0x00007f60b42b2a6c /usr/include/bits/string_fortified.h:59:10
#10 0x00007f60b42b2a6c PyImport_AppendInittab /usr/src/debug/python3.12-3.12.0-1.fc39.x86_64/Python/import.c:1
502:5
#11 0x0000000000480faf lldb_private::ScriptInterpreterPythonImpl::Initialize() (/build/llvm-build.f39/tools/ll
db/unittests/ScriptInterpreter/Python/./ScriptInterpreterPythonTests+0x480faf)
#12 0x000000000044cded PythonTestSuite::SetUp() (/build/llvm-build.f39/tools/lldb/unittests/ScriptInterpreter/
Python/./ScriptInterpreterPythonTests+0x44cded)
#13 0x0000000000441789 PythonDataObjectsTest::SetUp() NameMatches.cpp:0:0
#14 0x0000000000465687 testing::Test::Run() (.part.0) gtest-all.cc:0:0
#15 0x000000000046a58a testing::TestInfo::Run() (/build/llvm-build.f39/tools/lldb/unittests/ScriptInterpreter/
Python/./ScriptInterpreterPythonTests+0x46a58a)
#16 0x000000000046abcc testing::TestSuite::Run() (.part.0) gtest-all.cc:0:0
#17 0x0000000000471d10 testing::internal::UnitTestImpl::RunAllTests() (/build/llvm-build.f39/tools/lldb/unitte
sts/ScriptInterpreter/Python/./ScriptInterpreterPythonTests+0x471d10)
#18 0x000000000046503e testing::UnitTest::Run() (/build/llvm-build.f39/tools/lldb/unittests/ScriptInterpreter/
Python/./ScriptInterpreterPythonTests+0x46503e)
#19 0x000000000042ab26 main (/build/llvm-build.f39/tools/lldb/unittests/ScriptInterpreter/Python/./ScriptInter
preterPythonTests+0x42ab26)
#20 0x00007f60af9f214a __libc_start_call_main (/lib64/libc.so.6+0x2814a)
#21 0x00007f60af9f220b __libc_start_main@GLIBC_2.2.5 (/lib64/libc.so.6+0x2820b)
#22 0x000000000042b1a5 _start (/build/llvm-build.f39/tools/lldb/unittests/ScriptInterpreter/Python/./ScriptInt
erpreterPythonTests+0x42b1a5)
```

One can reduce the list of failures to 2 by guaranteeing the critical code in `InitializePythonRAII()` is executed only once.
But it still doesn't solve all the cases.
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJzMWdty2zgS_RroBWUWCN7ABz34stpxlbPjijObRxUINiVMIIAFgLa1X78FUJJF2Y5nstHspBIpvOj0Od1N4ADkzsmVBpij4goVNzM--LWxcz8oaTazxrTb-de1VIC93Uq9wt7goW-5B6xU24TDJ2O_4Sfp1_h-69dGY5T9A2U3OEtSiug1vsWdGXSL_RpwZ5QyTwFHOjcAyi4RuUFk9_ngufXh4jHaHsavwQKWDgvTAtbmCfcWHkHHHwTswfEVYNNhVJL77e2mN9YvL_sedHurpfe8QSXBvPNgx1uW4bTkSv4HEGWI1qgkycjkF_MEj2BDXC6Ese1OOiqu_Fo67MxgBYxUhNlsQHtU3CDK1t73LsiiC0QXK-nXQ5MIs0F0odTj_uuit-Z3EB7RRaNMg-ii4imwimUFK0GImgCkRZdSUTVVWdV1lmZNk1FgEaANvxgpILq4V8NKaofo4kFY2ftb7cH2Fnzgvxiz-NbF8Uoi-h7R7I6xi7uahCRMa4JKsvsbD78CFlxr47Ew2luj8NOaewzPHqzmaszIhm_xmj8Cbo0G3EBnLOAVeL_LYkxhb6T2WGp8d3dzhej1iC-1UEPMdm98KC5XKoKFU1xZ4O0Wy0Pd2l2XJEnyJt3x80uIFzqHD27fLS-d2HGpBgvu-8IXXCpo8Rdw3mFEWVof5wrHp-Fi0NLjcDK7xN8tRvJ-QWIERBcE0QUlZ4NPj-F_Pvq52Z-ZPj0z_ey89PMz0y_OS788M_3qvPTZeenTs7I_b2eeuTHP25flWdGr86aGnZV8fYT-5hT8NTi66bxrBt8P_qNZ13O1d4JgrbGB7Tvu7v0r0d1FWxKcSxM8jAqz-WgG33KCMfourh20lxvAznMfLOux_zjmfj1YC9pjvw42BZNnQgipupI0rCpFRkjwDRvjPLYgwo2BBe6kdX7qJVB2rc1edWf5BoKlHi8impFjaFLUjYAGR3cZi-m2bvzPvZXaP3guvn2xPFhF9nKT5U9L47wFvkG0DD5X6sACR_2LZpCq3ZvVeJB0WSiyks34eXf3708XI6eUraRPnEH0ijxXkc4hhYFvesK3przBD3KlufqF61aFbmO78ONpF11pdknivwMQPQLiHSes5gQvlxacNxaW1u_YK9mU-fgtEmeSMjLLoOZkQiyb4hWcZTleLvuxgMtvUqml3PQKgr_nXoa1zXcC1IRl-SRAfkqYAeCVixo_4MoAJlDFBKruCOs6zBvzgWhasq6bAJXH1cizggvOMaKLwYWH3lmB6KKFZlghuuhjC4YV2EX4SMhFmnQiq5NnVi5jtMMg0W-V7EBshYJEoOySVimdVq_6iwIzetI27CRwQyj58cCfTDsoCINexwfl12MHx9ApyYpp6HoSmjaUl-Il9LjYCWu4RsZh1Hkr9WrZGetlJ6FN1ii7LOoIvRtpaJaSt0DfHvl-Qn5lhB31jRwKEipbvBDaP-Djn5yRjndxjln2Vj6OgybKLt-ZQ243vRpvOB2FPxqMvDHKxQsjl7guDtOa301L_-O0dkWeRzGHByiopVO1uWgPy9Dwu4dBHgSD_63_s1L-kIjj-ekPS4lMJ1KyEylpxeqdlBvu-a_N7yC8CxCvBf2Lb-AT92INb4zWATyfgpdFySocREm9GuFegD8P-iVPSc-tT8JQjVfh_guuVCLE6wjFSQReMP46wq3uzBtR_t_ViGwn1ShP5TRCvJZz1F8_lrVqGqZK25RMw0g97uaMR79p6WMeD8_p50FfKrXT8sP5HBn9tAc16pjkk502IMlgKnQv7e_YHoHtRE49lUN5Q0u84VL_ZLrvER2ZvEM3sjmmS8mJYaFpzvFyGezJ0nlu_TLY3-WRgHccDEvzyXNC01NkSpopcgBFOfnn3e3V9ZImNCk-CEFJMwlxMsbTJuUFHsH_kmyPTN5tjsjnhfBbC65fddypxRbaQUBceinpPDbdYcMTe4MpbrZ4NXDLtQfYb44KK70U--3cUKCSvEzOI53Pl7e3h21zLB2GZxCDhxYbrbbYaAG7PdmrwWPpsfNSKdwacBrRymNn1CPgsASKIbkDl8zaedbWWc1nME_LmuVpntdstp6noiU8Z0VXiiqvocyzqil5yjKaiTzL-EzOKQneiFZplrOUJQBtm-ZVSkpGWA0pyglsuFRJqFhi7GoWX0HMK5IX2UzxBpSLL0Eo1fC0ez9BKSpuZna-q_LKoZyENLoXFC-9im9PYsGLG3xvnJONAtxCcPojEn5ag8bj9vPr1ySzwar5n351EIHj1kGQ8N8AAAD__zx-EF4">