<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/66273>66273</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            gtest-message.h patch could be upstreamed to googletest
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            new issue,
            third-party:unittests
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          pogo59
      </td>
    </tr>
</table>

<pre>
    As part of the upgrade to googletest v1.14.0, support for LLVM specific types (e.g., StringRef, raw_ostream) was preserved from previous versions. Support for raw_os_ostream in gtest-message.h would likely need a new extension point which should be doable but likely needs to be discussed with GoogleTest maintainers. Or, an alternative scheme for supporting these LLVM types might be feasible, as described by [GoogleTest documentation](https://github.com/google/googletest/blob/main/docs/advanced.md#teaching-googletest-how-to-print-your-values).

Support for raw_ostream currently makes use of that extension point, and adds another header to our copy of googletest.

This ticket has two goals:
1. Determine whether we can make support for LLVM types less intrusive.
2. If we do need to make an intrusive change, see if we can minimize that and hopefully upstream any necessary customization points to upstream GoogleTest.
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJx8VMGO2zYQ_Rr6MrAgUbZjHXTYZOGiQIoCTdBrQZEjkQ1FCpyhXefrC0q7620C9GKL4My8mffeUBG5KSD24vhRHJ93KrONqV_iFI_dbojm3j8RLCoxxBHYIuRlSsogcIQpxskjIzFcm6o5VLWQn4DyssTEMMYEnz__-RvQgtqNTgPfFyQQ8ozVVJXQL5xcmP7AsRySuv0ViROqWcgObopgSUiYrmhgTHEux6uLmeCKiVwMVMGXd2Bbgdca4AJMpbf9jERqwsrCLWZvwLtv6O8QEA0oCHgD_IcxlIqwRBcYbtZpC2TX8AHBRDV4hCHz-2QqHJRbRzoToYGbYwu_rKx8LazMygVWLmCiCn5PZUoVQHnGFBS7KwJpizOu7b_w5sJUeCbcyNs4m91kuWCNqMgNHtdSBAZJJzeggeEO4vjxHbaJOs8YWLGLQRyfhTxb5oVE-yTkRcjL5NjmodJxLoc18e2j8CbkZfBxEPJSxhDyYqImIS_KXFXQaKrZCNkyKm1dmPaPxL2Ntz3H_ZJc4P095rS_Kp-RhOwqUT-L-mn7_Vm8TTmdU8LA_g6z-oYEmXBzn-IfpdooNaCMIVAhssUEFpXBVNSJOYGOy72kPxr8TxNfrSNgp78hg1UEfCvGVn4lao1oKnhGxjS7gHCzuGLcELQKa4M_O34TzSMRuMApk7viC6is4NexZJu4OZDjVkSFRyxoq8K0ikyI4MY3OBfc7L7jxkUZ3MYFx-z9HfLyQp8KxZ-6uD7dQWfiOLvvqw820lbjvoU_PFPtTN-aru3UDvvm1B1Obd0ezzvbnw7yiE1zGI2SRh2a4_nQjq3-cKg7fe5ks3O9rGVbd03bnNuuOVdyGE-nU90Num7NUZ3EocZZOV95f52rmKadI8rYn07yQ7vzakBP6yMkZdnI9VJIKeQnISVbl8y-vEJ30T7l4LjISOX--LxLfam5H_JE4lB7R0wPFHbssf_xIVgUawv6db9fudjkeBhll5Pv_2drCsrL335J8W_UZWvW3sumrLP9GwAA__-VAN8l">