<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/66268>66268</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            gmock-matchers.h patch could be upstreamed to googletest
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            new issue,
            third-party:unittests
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          pogo59
      </td>
    </tr>
</table>

<pre>
    As part of the upgrade to googletest v1.14.0, there's a patch made some time ago to googlemock/include/gmock/gmock-matchers.h described as "support std::begin/std::end". In my own non-LLVM googletest work I haven't run into this, but it's not obviously in support of anything specific to LLVM either.
There's a [gist](https://gist.github.com/zeroomega/fb24b1d1c4252b852200e15fda29384d) which has a lot more than this one patch in it, but if you look at just gmock-matchers.h in that gist, that's the sum total of the change.

This ticket has two goals:

1. Understand exactly what triggers the build error that prompted the patch in the first place.
2. If it's not something specific to LLVM, propose the change to upstream googletest.
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJxslE-PozgQxT-NuZSCwIR_Bw6ZaUUaafa2u3eDC_C0cSG73Nnsp1-ZTvdEO3NCcTmu93v1bBWCWRziIOovon7JVOSV_LDTQnWfjaTvwyXArjwDzcArQtwXrzQCEyxEi0XGwPBW5uU5L4T8mjZ5FLINoGBXPK2wpf2BNgQ2G4Ja6Oe_N5pehbwaN9moUcjr8lg5vqctHYA-5CtoDJM3I2pQAYSUIe47eYbAWlQXUV1GXIwT8vq5gE4LKXP45mC7A90cOHKn79___uNZ-o38K3yDVb2hE7Jl8NGBcUzAqwmJaIwMhg8kRww0vhmKwd7BOPhQQTMod-fVuAXCjpOZzZQoj25okim5KF5EcfnzyR9Rf1lMYFG_CNmtzHtIyuU18ZvA-WJ4jWM-0Sbk9V_0RBsuSsjrPMrzWOpyOstajl0tZVFgWc9ayb7qzlrIHm6rmVZYVWpkiWEjj8CrcgcYkMPHfIw78B6gM9wpgiV6BcXwIwaGX2Zh0hmK4RB_zFy9-5MSEuIGTKzsR2SmVbkFH_gfJpgAbKZX5EMh31IglD34n_aVOfzlNPrAymnAf9TE9g631Ju9WRb07z3HaKwG9J78u7Ld07Yz6qP6iZl-zMYHht2q6UNSisj8POGU1d-PMsHunnYK-ISWqnEP7FFtT9HKMz1Uuq96leFQNv25kV3f1Nk6tI0u2ka3dd-2eppG7EbUUs1Frdq2LebMDLKQVdGXVdmVTVHneu6aru2remyrHudZnAvclLG5tW9bTn7JTAgRh6aRTZdZNaINx6WW0uENjqKQUsivQkpejdendKvvorpEZzjJDalev2R-SGeexrgEcS6sCRx-dmHDFodfAvHu8ETRahjx04zk__M7kUVvh__n_Cniqc3jc9o9_cCJ0-OQxAchrwfcfwEAAP__LGGSWg">