<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/65122>65122</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            llvm-windres handling of unescaped quotes broke building xz
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            llvm-tools,
            regression
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          mstorsjo
      </td>
    </tr>
</table>

<pre>
    The recent change (in 17.x) for llvm-windres handling of unescaped quotes in 0f4c6b120f21d582ab7c5c4f2b2a475086c34938 (which in itself fixed one aspect of https://github.com/llvm/llvm-project/issues/57334) instead broke use of llvm-windres in building xz (an llvm-windres specific workaround in https://github.com/tukaani-project/xz/commit/6b117d3b1fe91eb26d533ab16a2e552f84148d47, which worked before no longer works with the current llvm-windres).

We shouldn't be trading one bug for another, as the change from 0f4c6b120f21d582ab7c5c4f2b2a475086c34938 is correct in itself (making llvm-windres behaviour closer to GNU windres), we can implement the GNU windres flag `--use-temp-file` properly, which should allow the GNU windres codepath in xz to work for llvm-windres as well.

A "fix" for this issue is up at https://reviews.llvm.org/D159223 - but to properly take that fix into use, xz will need to remove its llvm-windres specific handling.
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJycVMuO4zYQ_Brq0rAhNSVZOuiw2YFzyylBzny0JO5QpMLH2DtfH1DOZmaySLDIxYaIflRVV7eI0SyOaGLdT6x7qkROqw_TFpMP8YuvpNdfp19XgkCKXAK1CrcQMByMg-ZyvjMcYfYBrH3ZTjfjdKAIq3DaGreAnyE7ikrspOGP7BNFMA7quVW9bLCesdHdgEJeVKfaGSWK9tLVQ694O_Kh9LmtRq0lyaRIdobZ3EmDdwQi7qRS6bGmtEfGPzG8MrwuJq1ZnpXfGF4Lrr_-TnvwX0glhlcTY6bI8NpdOG8LB-NiIqFBBv9MkCOVuh9IGQcyG6sLr_trgSbcx4iCx8xGwc2HZxF8drpk_Qe6lJ-FcOYdsvsrw6vy22bKVy-b5qK5bGYaG5LY645zIZteIHUdzkPbtINuLww_w0Oo0po0SJp9IHAerHcLheM9ws2kFdJKoHIIZZ7v8TMcz6x-YvWnx-_vBHH12WrH8JJAEqQgDvpFfZmXY_DC-bRSKAhEfNR-eGQOfvvxSZsIyodQBvo2a4bDJp5Lxw86S1rFi_E5gLI-UoDk4edffoM3HoceBEo4MNtuaStcC7Z3YTBbsQDr69MpRzol2vbTbCyxvoY9-J2C_fqm60MJENb623eVlNe0i3TY9P5a4BS5v98LEeFG1n5Q-RMwxNncGeKRkFYT4fBn0STvINI_HBToxdAtnkvpsw8Lw-tT042IHE4gcyr9vxGAJJ4J0ipSWRwwLvli7sLr_go3Yy04Il1SAm3-hYr0_-Lqb1t9rvTE9chHUdHU9CNvcejavlonLcexV1rxtuFNq8dRyLFtRlJjwxVpqsyENfJ64DXW7Vj3Z9VwURyghwu2o5SsrWkTxv5NrjqkmPquQayskGTjcasQD5DJexsZIsPPDDHQEihG41156p6qMB1RMi-RtbU1Mb3JViWTLE0_frgep-HdDahysNP_vz0Hpz8DAAD__7941ys">