<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/63842>63842</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            APFloatTest: convert test accidentally ended up with `x87DoubleExtended` -> `x87DoubleExtended` noops.
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            new issue
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          eddyb
      </td>
    </tr>
</table>

<pre>
    It looks like back in 2013 (https://github.com/llvm/llvm-project/commit/b361adbb64535677d617e2680b06cc0283b07d1a), tests were added for these conversions:
|`IEEEsingle` -> `x87DoubleExtended`|`x87DoubleExtended` -> `x87DoubleExtended`|
|-|-|
|`APFloat::getSNaN(APFloat::IEEEsingle)`|`APFloat::getSNaN(APFloat::x87DoubleExtended)`|
|`APFloat::getQNaN(APFloat::IEEEsingle)`|`APFloat::getQNaN(APFloat::x87DoubleExtended)`|

The first column (`IEEEsingle` NaNs) makes sense, and it fits with the commit description:
> APFloat: Make sure that we get a well-formed x87 NaN when converting from a smaller type.

But the second column looks like a mistake - the simplest explanation I can think of is they were meant to be `IEEEdouble` (which is still smaller than `x87DoubleExtended`, and so it would also fit the commit description) *not* noops.

cc @d0k
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJyclM-S2ygQxp8GXbrswiAh6aCDk7Gr5rBTu7V5AQRtizUCl2jF47ffQvZknEqy2eTgPyVo-PXXnz6dkjsGxI5VH1j1VOiZhjh1aO21L_por90zgY_xlMC7E0KvzQlcAME3EphoBqJzYnLLxJ6J_dHRMPdrE0cm9t5_fvtZnaf4DxpiYm_iOLr8p5dqo23fq7KSlaprqzY1CtXwnitjuGhkz2u70Uy0THwEwkQJLjghaGvRwiFOQAMmBBPDZ5ySi2Eh4U-Mb1n9kSn-vNvtkgtHj0xxWDG5A6b4a1M_xbn3uHslDBYtU_y2_3srPy17u291_zwCbP_c-6gpY8ntEenvF_3CRPPV4wdI0X5B-T-V3xJ9OeA_GP76bYbvVf6UYfn-NCAc3JQITPTzGLJ1vpnPi35JTLQw6hMmSBgS5snrYMERHFyev6MhTx1uNgKLyUzuTC6G99HLHbwjwh_6hJDmCYEGTXBBOCKBhgt6vzrEaUQLr02db4fLgOFuJ3LhCIcpjqAhjdp7nICuZ1w_tvVhpoUmoYnBvvX28LpoGF2iTLC6bXTj2WMiwNez10FncHgGowPQ4MIJ4gFcyluvN6-PqAMBRegR7oLZRe4sGBPNZXBmyCWJnPfvpIMOP_TsXdMUs6yXOHsL2qeYFf6RtqIFJrYhEhNbCDGe01c6GAOs5JafCttJ28pWF9htVNMKuZFNVQzdgQu0pSmlRdXWoqqU4WWpsBRlWXMlC9cJLiSvN5KrSolq3WwaVFj3bY38UEnNSo6jdn6dA2Udp2PhUpqxU7IpReF1jz4tKSZEwAssi0yIHGpTt4RQPx8TK7l3idL7KeTIY3c3zCdMi2nuHlhSB7QxzmIg7f0VFhVhPt-s-DuZcdevmCff_XJ8Lm0lJvZL2_8GAAD__zwvzDw">