<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/62314>62314</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            [clang-tidy] bugprone-assert-side-effect no longer warns since warnings on system macros are disabled
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            bug,
            clang-tidy,
            regression
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          carlosgalvezp
      </td>
    </tr>
</table>

<pre>
    I noticed that `bugprone-assert-side-effect` no longer warns when using real-world `assert` coming from `cassert` - this is because warnings on system macros are disabled globally.

The reason why this was not caught in our tests is because the fake `assert` is defined in the same file as the test, instead of being included as a system header (which is what happens in the real world).
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJyMUk2P4ygQ_TX4UnJk4zhODj70dhRp7_sHCigDuxgiCneU_fUj3NPT0xppNBeQ6uO9ek8Pmb2NRLMY_xLjtcGtuJRnjTkkthje6P97o5J5zn9DTMVrMlAcFhCnTm32nlOkFpkpl5a9oZaWhXQRpw5igpCipQwPzJHh4SjCxj5ayIShfaQcTMV5X68rOq21veS01ob-7LRQnGfwDIo0bkw7qI-WIUXgJxdaYUWdEwNmAuMZVSADNiSFITwPoruK7uX9_cdRvYFThId7vkM_kKtC0LhZV8BHSFuGQly-0BZHsOB_9PVwz2Bo8ZFMXawzjCvB4gMB8l6oSEK-go9cCA2kBRRVtT7qsBkydRA_pDhCQxmEPD-c164SPKrtDu93ivzBUo2E3UghL4fGzIO5DBdsaO5PZynHYeqnxs2dGunc0aQkLdoMeupHRWctx0HjWZ-mxs-yk0N3lEMvj_04HXrdT5fLNMlRnfV06cWxoxV9OITwth5Sto1n3mg-yaE_NgEVBd4zJKXarJBSyFchpQ4YbVu8ef4oZbKZmH2KtTRemzxXzFZtlsWxC54Lf7IUX8Iezp-Qxiv8Jnq_5I591H8al2bLYXal3FkML0LehLxZX9ymDjqtQt7qXd-_9p7TvzXq8rZbwULedje-BQAA__9fFR-9">