<table border="1" cellspacing="0" cellpadding="8">
    <tr>
        <th>Issue</th>
        <td>
            <a href=https://github.com/llvm/llvm-project/issues/60661>60661</a>
        </td>
    </tr>

    <tr>
        <th>Summary</th>
        <td>
            clang-tidy: bugprone-unchecked-optional-access does not understand custom assertion functions
        </td>
    </tr>

    <tr>
      <th>Labels</th>
      <td>
            new issue
      </td>
    </tr>

    <tr>
      <th>Assignees</th>
      <td>
      </td>
    </tr>

    <tr>
      <th>Reporter</th>
      <td>
          mineo
      </td>
    </tr>
</table>

<pre>
    See https://godbolt.org/z/dqeEd5bc8, reproduced here:

```
#include <optional>
#include <assert.h>

extern void noreturn1() __attribute__((__noreturn__));
[[noreturn]] extern void noreturn2();

void intermediate1(bool cond) {
    if (!cond) {noreturn1();}
}

void intermediate2(bool cond) {
    if (!cond) {noreturn2();}
}

#define intermediate3(cond) (static_cast<bool>(cond) ? void(0) : noreturn1())

void useSafely1(std::optional<int> opt) {
 intermediate1(opt.has_value());
    *opt;
}

void useSafely2(std::optional<int> opt) {
 intermediate2(opt.has_value());
    *opt;
}

void useSafely3(std::optional<int> opt) {
 intermediate3(opt.has_value());
    *opt;
}
```

clang-tidy warns about an unsafe access of `opt` in `useSafely1` and `useSafely2`, although they behave similar to the assert macro.

It would be great if it was possible to at least configure clang-tidy to understand that some assert-like functions exist that make accessing the value in an optional safe, similar to how some other checks (like `cppcoreguidelines-owning-memory` and `cppcoreguidelines-no-malloc`) can be configured to know about more functions.

(It would be best if no such configuration was necessary, but I understand that it's impossible for clang-tidy to know about function definitions of assert-like functions in other translation units)
</pre>
<img width="1px" height="1px" alt="" src="http://email.email.llvm.org/o/eJysVtuO4ygQ_RryUkqEoZM4D3mY6e5I8zwfEGEo22xjyELRmezXr3Bu7kyvVtpeCZFwq3PqHC5WKdnOI27Z8jtbvsxUpj7E7WA9hlkTzGn7ExF6okNi8hsTOyZ2XTBNcLQIsWNi9xcTO_Mnvpplo2smniHiIQaTNRroMWJZxl8Yv9YrfinnppDWa5cNApPP4UA2eOWYfP1sWKWEkRb9fXis8Rdh9PAerAEfIlKOvmKiZmID-70iirbJhPv92Ffv99dJpWdTivx-iVdE-H4dZssXtnyBz8KLc_j7wrEep1hPGAc0VhEWFk0IDnTwptBh68sCAADbwhimmow-8C8A65cLxu3P52DiP4OJfwVjQhpsrccPiJKJ-hZO1IkUWb3XKhGTz4VKMWoyRe5GFZmo-bn97dGvUh5zzAl_qhbdqRoxTNlQ8tt9qzxbT0y-QjjQx6wfnQgHWvQq7d-Vy3jHkxOVmCiB77Z-IvmNjvgCHfH_05FfoCO_SOfhTI-1dsp3c7LmBEcVfQLVhEygPGSfVIugtMaUILTAVrzEXXGwvjQmjq84KG8-dIoCJJ5BOepD7nqgHk_QYK_eEZIdrFMRKJRuON8YMCgdw2LK7gfBMWRnoEHoIioqB8QSHFWCQ0jJNg5LEEXgUCUqh6q1XY4Ik8QoQPYGY6JCknpFkMJwhZ07-4bQZq-LGQnwl010njWot6sA1ncj1VH3IoDycLUPilAl10lafTieQQL1GEH3qN9SOX4jGltxfTjoELHL1qCzHtM8HL313XzAIcTTRNLfZ_owH5RzQY8ab0ArXxS6JW8Kgzcfjhc3hxAnGS4-Xhn1VOQG06ixD5Cy7m8hVVk5yu6xyKHiqSTcZIIfv4lriYl1AjvcLGpDfDBkwu5KDMa7y55dCO0_2GP9RVKKyid3Jpa9pcTEZma20mzkRs1wW63WKy5FXVWzflsbxesWBV-KteLLmhv9ZFrkYrXUVYPNzG4FF5KLilfiiVfVotVKaqx5LVsppVyzJ46Dsm7h3PtQHtWZTSnjdsVXq2rmVIMujc-zEB6PMA4yIcprHbdlzbzJXWJP3NlE6R6FLDnc3sUp122Tu0MMHufZjxsHzfy61-aX82gCJvCBpuLrnCgMF92KLDfVZjm67cPngaU-NwsdBiZ2hc3lZ36I4Q_UxMRuzCExsRtz_DsAAP__Bn2x6w">